Skip to content

Conversation

@carlos-castillo-jask
Copy link
Collaborator

@carlos-castillo-jask carlos-castillo-jask commented Feb 24, 2025

Purpose of this pull request

This PR add documentation for a new Bitwarden Cloud-to-Cloud source.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

CONN-4169

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Feb 24, 2025
@carlos-castillo-jask
Copy link
Collaborator Author

The new integration is not ready yet. I will convert from a draft PR once we are tested and ready for release.

@carlos-castillo-jask
Copy link
Collaborator Author

Ready for review :)

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes!

carlos-castillo-jask and others added 4 commits February 25, 2025 15:50
…amework/bitwarden.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@carlos-castillo-jask
Copy link
Collaborator Author

Great suggestions. Committed.

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-castillo-jask , sorry, I caught one more thing! Can you take a look? After that, would it be ready to merge? Or does it need to stay on hold?

…amework/bitwarden.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@carlos-castillo-jask
Copy link
Collaborator Author

All good. Yes, we should be good to merge whenever you're ready.

@kimsauce kimsauce enabled auto-merge February 25, 2025 22:22
@kimsauce kimsauce added this pull request to the merge queue Feb 25, 2025
@jpipkin1 jpipkin1 removed this pull request from the merge queue due to a manual request Feb 25, 2025
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Feb 25, 2025

@kimsauce, I pulled this PR out of the merge queue because we need to add the article to the left nav, the index page, and the product list article. I'll do that now. I DM'd @carlos-castillo-jask and told him I'd do that.

@kimsauce
Copy link
Collaborator

kimsauce commented Feb 25, 2025

@kimsauce, I pulled this PR out of the merge queue because we need to add the article to the left nav, the index page, and the product list article. I'll do that now. I DM'd @carlos-castillo-jask and told him I'd do that.

Thank you, @jpipkin1 ! Great catch.

@jpipkin1 jpipkin1 requested a review from a team as a code owner February 25, 2025 22:46
@jpipkin1
Copy link
Collaborator

@carlos-castillo-jask, I added the article to the left nav, the index page, and the product list article. I also trimmed the logo a little. See commit "Add to left nav".

@jpipkin1 jpipkin1 enabled auto-merge February 25, 2025 22:49
@jpipkin1 jpipkin1 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 2d830ca Feb 25, 2025
5 checks passed
@jpipkin1 jpipkin1 deleted the CONN-4169-Bitwarden branch February 25, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants