-
Notifications
You must be signed in to change notification settings - Fork 228
CONN-4169 Add docs for new Bitwarden integration #5107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The new integration is not ready yet. I will convert from a draft PR once we are tested and ready for release. |
…documentation into CONN-4169-Bitwarden
|
Ready for review :) |
docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework/bitwarden.md
Outdated
Show resolved
Hide resolved
docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework/bitwarden.md
Outdated
Show resolved
Hide resolved
docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework/bitwarden.md
Outdated
Show resolved
Hide resolved
docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework/bitwarden.md
Outdated
Show resolved
Hide resolved
kimsauce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes!
…amework/bitwarden.md Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
…amework/bitwarden.md Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
|
Great suggestions. Committed. |
kimsauce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework/bitwarden.md
Outdated
Show resolved
Hide resolved
kimsauce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-castillo-jask , sorry, I caught one more thing! Can you take a look? After that, would it be ready to merge? Or does it need to stay on hold?
…amework/bitwarden.md Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
|
All good. Yes, we should be good to merge whenever you're ready. |
|
@kimsauce, I pulled this PR out of the merge queue because we need to add the article to the left nav, the index page, and the product list article. I'll do that now. I DM'd @carlos-castillo-jask and told him I'd do that. |
Thank you, @jpipkin1 ! Great catch. |
|
@carlos-castillo-jask, I added the article to the left nav, the index page, and the product list article. I also trimmed the logo a little. See commit "Add to left nav". |
Purpose of this pull request
This PR add documentation for a new Bitwarden Cloud-to-Cloud source.
Select the type of change
Ticket (if applicable)
CONN-4169