Skip to content

Conversation

@sumoanema
Copy link
Collaborator

Purpose of this pull request

This pull request is to update GCP VPC doc with additional dashboard and monitors which are newly added to the app

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/SUMO-258860

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Apr 16, 2025
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumoanema, I made minor changes (see commit "Updates from review").

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumoanema, the article looks good, but you still need to add a screenshot for one of the dashboards.

@sumoanema sumoanema requested a review from jpipkin1 April 16, 2025 16:22
@sumoanema sumoanema added the do-not-merge Pull requests that should not be merged label Apr 16, 2025
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @sumoanema. I made some minor changes (see commit "Updates to dashboard descriptions").

@sumoanema sumoanema removed the do-not-merge Pull requests that should not be merged label Apr 18, 2025
@sumoanema sumoanema added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit acbd223 Apr 18, 2025
5 checks passed
@sumoanema sumoanema deleted the gcpvpcupdate branch April 18, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants