feat(client): update request timeout policy at runtime - #593
Merged
Conversation
SunSi12138
marked this pull request as ready for review
September 7, 2026 14:25
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #578
Scope
Adds runtime request-timeout policy replacement for future logical calls without rebuilding or reconnecting the client.
ISharpLinkClient.UpdateRequestTimeout(TimeSpan)atomically publishes an enabled custom fallback.ISharpLinkClient.DisableRequestTimeout()atomically publishes a disabled fallback.GetRequestTimeoutPolicySnapshot()exposes the current immutable generation, source and effective timeout.Regression
SharpLinkClientRuntimeRequestTimeoutTestscovers:Branch head:
27d13b6216b35ac2b678d41a4acb80902ee45269.Target validated by PR merge ref:
dev@f643aee53e411fa2a6825cf484787069468f9c64.Validation
34131406970: PASS — Release build, full Unit/Generator/Load tests, formatting/maintainability and deterministic allocation gate.34132885891attempt 2: PASS. The first attempt hit two unrelated existing timing flakes outside the changed Client timeout surface; rerun on the identical merge ref passed the full suite.34131406982: PASS.34132910880: PASS — Debug/Release builds, full Integration Tests, NativeAOT transport/topology smoke, package verification/smoke, demo/load smoke, and desktop cross-platform codec compatibility matrix.