Skip to content

Fix the shared-renderer client contains-check pattern - #25

Merged
SunkenInTime merged 2 commits into
weaver-mainfrom
agent/fix-reconnect-check-pattern
Jul 31, 2026
Merged

Fix the shared-renderer client contains-check pattern#25
SunkenInTime merged 2 commits into
weaver-mainfrom
agent/fix-reconnect-check-pattern

Conversation

@SunkenInTime

Copy link
Copy Markdown
Owner

The slice-3 review hardening reworded the disconnect log to 'host gone or wedged, will reconnect' after test-macos-shared-renderer-client pinned the original phrasing, so the check fails on weaver-main (caught by weaver CI in SunkenInTime/weaver#47). Pin the invariant — the reconnect promise — not the exact prose. Verified: the check step passes locally.

The slice-3 review hardening reworded the disconnect log to 'host gone
or wedged, will reconnect' after the check step pinned the original
phrasing; pin the invariant ('will reconnect' — the reconnect promise)
rather than the exact prose.
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

This change corrects the macOS shared-renderer contract check so it matches the exact reconnect message emitted after a timed frame-send failure.

The executed source check confirmed that the previous phrase is absent from src/platform/macos/appkit_host.m, while the replacement phrase occurs at line 992 in the timed frame-send failure branch and is followed by session teardown and a refused present.

T-Rex validation blocked

The repository's native check could not be run because the zig tool is missing from the environment. A dependency-free validation exercised the same literal substring behavior for this static assertion. Configure VMs

Confidence Score: 5/5

Safe to merge: the assertion now tracks the exact reconnect message emitted by the intended macOS frame-send failure path.

The final defect set is empty. Executed validation confirmed that the replacement text is present in the intended branch and that the obsolete text would not match the current implementation.

Files Needing Attention: No files need further attention. build.zig and the matching reconnect branch in src/platform/macos/appkit_host.m were checked.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the dependency-free shared renderer reconnect validation script for old and new expectations; the old assertion was absent and the new assertion was found in the timed mach_msg frame-send error branch, and Zig checker was unavailable.
  • Execution record shows the validation harness exited with status 0 for both old and new runs, confirming the old case absence and the new frame presence, and notes that Zig checker is not installed.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "Pin the exact reconnect log line, not a ..." | Re-trigger Greptile

Comment thread build.zig Outdated
Review is right that a bare 'will reconnect' substring could be
satisfied by unrelated prose; pin the frame-send failure branch's
exact current line instead.
@SunkenInTime

Copy link
Copy Markdown
Owner Author

@greptileai review

@SunkenInTime
SunkenInTime merged commit 6678343 into weaver-main Jul 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant