Skip to content

fix(types): make renderer typecheck clean#518

Closed
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/perf-renderer-typecheck-clean
Closed

fix(types): make renderer typecheck clean#518
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/perf-renderer-typecheck-clean

Conversation

@JustYannicc

Copy link
Copy Markdown
Collaborator

What changed

  • Corrected renderer TypeScript mismatches across launcher command/profile types, inline refs, settings handlers, and Raycast runtime helper types.
  • Added an ambient declaration for the existing liquid-glass-react renderer import so the renderer project can typecheck without a missing-module diagnostic.
  • Kept fixes behavior-preserving: local type narrowing, signature alignment, typo correction for a timer ref, and compatibility type exposure for existing runtime behavior.

Why

Renderer performance PRs were inheriting existing repo-wide TypeScript noise. The baseline renderer project check failed with exit 2 and 46 diagnostics across 20 files, so unrelated work could not rely on a clean renderer typecheck signal.

Compatibility impact

No behavior removal intended. The changes align TypeScript declarations with existing runtime behavior and data shapes. User-facing strings were not added, renamed, or removed.

How tested

  • Before: ./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty false exited 2 with 46 diagnostics.
  • After: ./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty false exited 0 with 0 diagnostics.
  • LSP: src/renderer/src scan plus targeted checks for raycast-api/index.tsx, hooks/useLauncherCommandModel.ts, settings/AITab.tsx, and utils/quicklink-icons.tsx reported no errors.
  • pnpm test passed: 24 pass, 1 skipped because live Electron is not launchable here.
  • pnpm run build:renderer passed.
  • pnpm run check:i18n exited 0; it still reports pre-existing Italian locale missing keys for settings.ai.whisper.vocabulary and settings.extensions.appSearchScope.

@JustYannicc

Copy link
Copy Markdown
Collaborator Author

Superseded by #532 (fix(validation): restore project checks), which consolidates this validation/build change with the related source PRs. Closing this PR in favor of the upstream replacement.

@JustYannicc JustYannicc closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant