Skip to content

fix(pnpm): approve native build scripts#528

Closed
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/fix-pnpm-native-builds-pr
Closed

fix(pnpm): approve native build scripts#528
JustYannicc wants to merge 1 commit into
SuperCmdLabs:mainfrom
JustYannicc:codex/fix-pnpm-native-builds-pr

Conversation

@JustYannicc

Copy link
Copy Markdown
Collaborator

What changed

  • Added pnpm-workspace.yaml with pnpm 11 allowBuilds approvals for electron, esbuild, extract-file-icon, and node-window-manager.
  • Kept the diff scoped to pnpm approval metadata; no npm lockfile changes.

Why

  • pnpm 11 blocks installs and command wrappers when native build scripts are detected but not approved.
  • The affected commands were failing before their requested scripts could run with [ERR_PNPM_IGNORED_BUILDS] for Electron, esbuild, extract-file-icon, and node-window-manager.

Compatibility impact

  • No application runtime code changes.
  • Allows only the listed native dependencies to run their install/rebuild scripts during pnpm installs.
  • npm-based installs are unchanged.

How tested

  • Removed generated node_modules, pnpm-lock.yaml, and dist before validation.
  • pnpm install passed noninteractively and ran approved native build/postinstall steps.
  • pnpm exec tsc -p tsconfig.main.json --noEmit passed.
  • pnpm run check:i18n passed; it still reports existing Italian missing keys: settings.ai.whisper.vocabulary, settings.extensions.appSearchScope.
  • pnpm test passed: 27 tests.
  • pnpm run build completed build:main and build:renderer, then failed in build:native because src/native/native-helpers-addon/binding.gyp cannot resolve node-addon-api under pnpm strict layout.

Stack validation

  • Clean branch created from origin/main; the previous integration-stack branch was not used as the PR head.
  • Cherry-picked only the pnpm/native-builds fix commit.
  • git diff --stat origin/main..HEAD: pnpm-workspace.yaml | 5 +++++.

@JustYannicc

Copy link
Copy Markdown
Collaborator Author

Superseded by #532 (fix(validation): restore project checks), which consolidates this validation/build change with the related source PRs. Closing this PR in favor of the upstream replacement.

@JustYannicc JustYannicc closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant