perf(renderer): reduce virtualized selection scroll churn - #604
Closed
JustYannicc wants to merge 121 commits into
Closed
perf(renderer): reduce virtualized selection scroll churn#604JustYannicc wants to merge 121 commits into
JustYannicc wants to merge 121 commits into
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
behavior: 'auto'.behavior: 'auto'.scripts/test-virtual-selection-scroll-behavior.mjsto assert the selected virtual scroll paths do not reintroduce smooth scroll animations.Why
Held arrow navigation can update selection faster than smooth scrolling animations complete. The List runtime already uses instant scroll for this reason; matching that behavior in Grid and Launcher avoids queued browser animations and the resulting retained animation/jank risk while preserving the same selected-item viewport math.
Compatibility impact
Selection semantics, virtual window inclusion, refs, focus handling, accessibility attributes, and scroll target math are unchanged. The only user-visible difference is that keyboard-driven selected-item auto-scroll correction is instant instead of animated in these virtualized surfaces.
How tested
node --test scripts/test-virtual-selection-scroll-behavior.mjs scripts/test-grid-virtualization.mjs scripts/test-launcher-command-list-windowing.mjsnode scripts/run-node-tests.mjs --exclude-perf./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falsenode scripts/check-package-manager-parity.mjssrc/renderer/src/raycast-api/grid-runtime.tsx: no diagnostics foundsrc/renderer/src/components/LauncherCommandList.tsx: no diagnostics foundnpm run typecheck:renderercould not run because npm is intentionally disabled on this Mac; the equivalent renderertsccommand passed directly.Performance evidence
Audit baseline on
codex/perf-wave4-integrated-stack-20260705atac90ce403aeddab98d0a1b245afce268c48b8bfd:node scripts/measure-raycast-grid-render-churn.mjs --iterations=5 --warmups=1 --selection-steps=800 --json:selectionScroll.scrollUpdates=743, median0.400875ms, p952.28325ms;selectionRenderChurn.cellRenderCount=1600, median354.815833ms, p95621.91025ms.node scripts/measure-launcher-command-list-render.mjs --iterations=5 --json:totalRows=122,totalMedianMs=3.494833ms.Local before on this branch before the patch:
selectionScroll.scrollUpdates=743, median0.425208ms, p952.916209ms;selectionRenderChurn.cellRenderCount=1600, median191.135208ms, p95219.773709ms.totalRows=122,totalMedianMs=4.451667ms.Local after this patch:
selectionScroll.scrollUpdates=743, median0.392667ms, p952.594583ms;selectionRenderChurn.cellRenderCount=1600, median178.294125ms, p95194.187708ms.totalRows=122,totalMedianMs=3.712958ms.Structural evidence: both virtualized selected-scroll paths now use
behavior: 'auto', andscripts/test-virtual-selection-scroll-behavior.mjsfails if either path switches back tobehavior: 'smooth'.Stack validation
Started from
codex/perf-wave4-integrated-stack-20260705atac90ce403aeddab98d0a1b245afce268c48b8bfd; verifiedgit rev-parse HEADreturned that exact SHA before creatingcodex/perf-renderer-virtual-scroll-churn-20260705.Replaces
Wave5 performance implementation thread. Replaces no prior PR.