perf(hooks): stabilize Raycast hook signatures - #613
Closed
JustYannicc wants to merge 121 commits into
Closed
Conversation
(cherry picked from commit 39b567a)
(cherry picked from commit 23ddb55)
(cherry picked from commit 59166b4)
(cherry picked from commit 83c2a89)
(cherry picked from commit 0a7560b)
(cherry picked from commit 17fb535)
# Conflicts: # src/renderer/src/raycast-api/hooks/use-cached-promise.ts
…launcher surfaces # Conflicts: # src/renderer/src/raycast-api/list-runtime-renderers.tsx # src/renderer/src/raycast-api/list-runtime.tsx
…IO stalls # Conflicts: # src/renderer/src/CameraExtension.tsx
# Conflicts: # src/renderer/src/raycast-api/list-runtime.tsx
…resh overhead # Conflicts: # scripts/bench-script-command-discovery.mjs # scripts/benchmark-file-search-delete-batch.mjs # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-file-search-delete-batch.mjs # scripts/test-script-command-runner.mjs # src/main/file-search-index.ts # src/main/main.ts
…hurn # Conflicts: # scripts/lib/script-command-runner-harness.mjs # scripts/lib/ts-import.mjs # scripts/test-extension-lifecycle-sandbox.mjs # scripts/test-script-command-runner.mjs # src/main/main.ts # src/renderer/src/ExtensionView.tsx
… hot paths # Conflicts: # scripts/test-use-frecency-sorting.mjs # src/renderer/src/raycast-api/form-runtime.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/grid-runtime-items.tsx # src/renderer/src/raycast-api/hooks/use-frecency-sorting.ts
# Conflicts: # .github/workflows/project-checks.yml # package.json # scripts/file-search-perf-harness.mjs # scripts/test-browser-search-performance.mjs # scripts/test-file-search-perf-harness.mjs # scripts/test-root-search-perf.mjs # src/renderer/src/CameraExtension.tsx # src/renderer/src/hooks/useBrowserSearch.ts # src/renderer/src/raycast-api/list-runtime.tsx
…cle and media fixes # Conflicts: # scripts/lib/ts-import.mjs # scripts/measure-extension-bundle-cache.mjs # src/main/commands.ts # src/main/extension-runner.ts # src/main/main.ts # src/renderer/src/ExtensionView.tsx # src/renderer/src/raycast-api/grid-runtime-hooks.ts # src/renderer/src/raycast-api/list-runtime-hooks.ts
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
usePromiseanduseCachedPromiseto the shared stable args helper, removing the direct render-timeJSON.stringify(args || [])crash path inuseCachedPromise.useExecrevalidation on command, argv, and execution-affecting options so dynamic hook inputs trigger execution again.Why
useCachedPromisecould stringify hook args directly during render, which made large arg arrays hot and crashed on circular args.useExecalso passed an empty dependency args list intousePromise, so command, args, or execution option changes could be missed until manual revalidation.Compatibility impact
Raycast hook API shapes and exports are unchanged. Callback and option refs continue flowing through the existing
usePromiseref path.useSQLalready keys dynamic database/query inputs, anduseFetchalready has a guarded request key.useStreamJSONoption-signature invalidation was left as a non-actionable candidate for this PR to avoid broadening behavior beyond the requested hook invalidation fix.How tested
node --test scripts/test-raycast-hook-signatures.mjsnode --test scripts/test-raycast-hook-signatures.mjs scripts/test-abortable-promise-hooks.mjs scripts/test-use-fetch-stale-runs.mjs scripts/test-use-stream-json-lifecycle.mjs./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falsenode scripts/run-node-tests.mjs --exclude-perfpassed with 317 passing, 1 skipped, 0 failures.use-stable-args.ts,use-promise.ts,use-cached-promise.ts, anduse-exec.ts.Performance evidence
node scripts/measure-raycast-hook-signatures.mjswith 500 iterations over 10,000 large rows:JSON.stringify: 463.667 msgetStableArgsKeyrepeated same identity: 0.061 msStack validation
Started from
codex/perf-wave4-integrated-stack-20260705base SHAac90ce403aeddab98d0a1b245afce268c48b8bfdand createdcodex/perf-hooks-raycast-runtime-signaturesfrom that exact commit. The localnpmcommand is intentionally disabled on this Mac, so dependencies were populated with runtime pnpm for validation only;node scripts/check-package-manager-parity.mjscannot pass in this environment because that install resolved several package versions differently thanpackage-lock.jsonexpects. No dependency files are included in the PR.Replaces
N/A