[pull] main from facebook:main#382
Merged
pull[bot] merged 9 commits intoSuperoldman96:mainfrom Aug 7, 2025
Merged
Conversation
Summary: Migrate com.facebook.react.views.text.TextAttributeProps to Kotlin. ## Changelog: [Android][Changed] - Migrated TextAttributeProps to Kotlin. You might need to update your property access to use camelCase instead of Hungarian notation. Pull Request resolved: #52452 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: rshest Differential Revision: D79341238 Pulled By: cortinico fbshipit-source-id: 455c7b48f47a0cf240aaf330e1fa3674798e7237
Summary: Pull Request resolved: #52978 This field is never written anywhere (neither in the internal codebase, nor in OSS). I'm cleaning this us and simplifying the logic: - Deprecating `effectiveLineHeight` - Replacing all the usage of `effectiveLineHeight` with just `lineHeight` Changelog: [Android] [Changed] - Deprecate the field `TextAttributeProps.effectiveLineHeight`. This field was public but never used in OSS. Reviewed By: mdvacca Differential Revision: D79442393 fbshipit-source-id: c424a6def0257264cd160a2d7be48c2d0f47135e
…abled (#53099) Summary: `#include <ReactCommon/RuntimeExecutor.h>` stopped working in react-native 0.81 when using frameworks because it is not part of ReactCommon anymore when the split happened for iOS. to fix this I am including RuntimeExecutor in search headers same way we include ReactCommon. ## Changelog: [IOS] [FIXED] - Fix import RuntimeExecutor.h with USE_FRAMEWORKS Pull Request resolved: #53099 Test Plan: You can enable USE_FRAMEWORKS and do `#include <react/renderer/uimanager/UIManager.h>` (which react-native-reanimated is doing). Build will fail complaining that it can't find ReactCommon/RuntimeExecutor.h which is included in UIManager.h Add my patch, it will work and build successfully Reviewed By: cortinico Differential Revision: D79796637 Pulled By: cipolleschi fbshipit-source-id: f8bb669cfb9f4414653655ed98d2cc6bb431a3e5
Summary: Pull Request resolved: #53145 # Changelog: [Internal] See attached tasks. Reviewed By: motiz88 Differential Revision: D79563948 fbshipit-source-id: a95b4e63d3a7d0d456c89ec7361e58fea0f5fb66
Summary: This test was still using the old `BridgeReactContext`, I'm migrating it to `BridgelessReactContext`. ## Changelog: [INTERNAL] - Pull Request resolved: #53131 Test Plan: CI Reviewed By: mdvacca Differential Revision: D79801564 Pulled By: cortinico fbshipit-source-id: 9bb96185505703a773597aeadfeeaeeb194532de
Summary: Pull Request resolved: #53143 # Changelog: [Internal] - This refactors the way Fantom benchmark test results are passed to the top level, making it type safe and more maintainable. Reviewed By: andrewdacenko Differential Revision: D79812707 fbshipit-source-id: d8bfef7e1b0c11b277a08f5e4c810f8c1efd7f89
Summary: There is currently a bug with Modals with New Architecture where the first frame is rendered incorrectly, specifically not accounting for all the vertical insets (only the status bar). This fixes it. Specifically: 1. I've removed the caching of the statusbar height from `ReactModalHostView` as that was not working correctly. Sometimes the value returned `0` meaning that it was not yet computed when Fabric was asking for it. In the updated implementation we now query `FabricUIManager` given the `surfaceId` of the modal. 2. I've modified the logic to account for all the vertical insets, not just the status bar. ## Changelog: [ANDROID] [FIXED] - Correctly account for insets on first render of Modals on New Arch Pull Request resolved: #52835 Test Plan: Tested on Marketplace Location Picker and the picker is still working correctly: https://pxl.cl/7NjtJ Reviewed By: mdvacca Differential Revision: D78975126 Pulled By: cortinico fbshipit-source-id: d7afb4fa5d2f43a7e33da3860432fa6dfe0dc8d7
Summary: Pull Request resolved: #52946 This just add a set of unit tests for `DisplayMetricsHolder` as I'm working on this class recently. Changelog: [Internal] [Changed] - Reviewed By: rshest, mdvacca Differential Revision: D78981753 fbshipit-source-id: 5800d44d3131a58770a0049eb2d08306874b7183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )