[pull] main from facebook:main#812
Merged
pull[bot] merged 3 commits intoSuperoldman96:mainfrom Feb 9, 2026
Merged
Conversation
…sistency (#55471) Summary: Pull Request resolved: #55471 Pragmatic rename of this type representing a JS module that exports a Yargs command definition, which we expose to module boundaries in various places. By naming it the same as `types/yargs` does, we don't need to give it any special treatment when translating Flow to TS. See eg: https://app.unpkg.com/types/yargs@17.0.35/files/index.d.ts#L205 Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D92613927 fbshipit-source-id: 8997811233807381a128afb75084f01338d43003
#55437) Summary: Pull Request resolved: #55437 This deletes some Paper specific paths in Text and image code, related to inline view handling (done in native component layer in Paper), and how padding is set. It also changed `Spannable` to `Spanned` in a couple places, in preparation of reusing `ReactTextViewManager` with state generated by Facsimile (for selectable text). I left the actions performed by Paper ShadowNode as something stublike, since that code should never be executed. `ReactTextUpdate` is made internal, since the shape of native component state is subject to change. Changelog: [Android][Breaking] - Make ReactTextUpdate internal Reviewed By: javache Differential Revision: D92459725 fbshipit-source-id: e1bc0f9a19adbf296fb1873913f9db319eb8b3f9
Summary: This PR migrates the `Pressability` tests so that it uses Jest modern timers. First, I centralized Fake timers setup in the `beforeEach` and restored in the `afterEach` (to run test in isolation with respect to timers). I migrated all the calls previously used to fire all pending timers (`jest.runOnlyPendingTimers`) to `jest.advanceTimersByTime`, setting the correct timing need for the tests to verify the entire `Pressability` flows (including minimum press duration and long press delay configurations). This should improve the correctness of the tests (demonstrated also by the test plan below). I also tried to increased the readability of the tests by extracting some constants (related to the inner configured delay/press duration of the `Pressability` class). ## Changelog: [GENERAL] [CHANGED] - Migrated `Pressability` tests to Jest modern timers Pull Request resolved: #55410 Test Plan: - Ran `Pressability-test` and verify all tests cases passed - Ran the full React Native test suite to ensure all tests pass. - Verified test correctness by intentionally breaking production code: - Modified callback invocation logic (onPressIn, onPressOut, onLongPress) to verify that tests were failing - Changed timing constants (eg. `DEFAULT_MIN_PRESS_DURATION,` DEFAULT_LONG_PRESS_DELAY_MS`)to verify that tests correctly failed Reviewed By: NickGerleman Differential Revision: D92750937 Pulled By: Abbondanzo fbshipit-source-id: 6d01f45f289138c504ccbb53104b219dbaed0bae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )