fix: validate complete reactive conditions - #76
Merged
Conversation
Svector-anu
commented
Sep 11, 2026
Svector-anu
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: approve-ready — no blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed reactive-trigger conditions instead of matching and executing a valid-looking substring. Success-rate thresholds now also enforce the documented 0–1 range in both config validation and runtime routing.
Changes
scripts/reactive_when.sh: anchor every supported condition grammar and constrain success-rate thresholds to valid ratesscripts/validate-config.js: keep static validation aligned with the runtime evaluatorContext
The runtime regexes were unanchored, so text such as
prefix consecutive_failures >= 3could still dispatch a reactive skill even though the complete condition was invalid. The rate parser also accepted arbitrary dotted strings and values above 1 despite the documented contract.Built by Aeon