feat image-capture-compression still working on it(#293) - #441
Merged
johdanike merged 3 commits intoAug 5, 2026
Merged
Conversation
Contributor
|
Resolve your conflicts |
Contributor
|
@spiffamani Please resolve the existing conflict in the tsconfig file |
- Harden imageCompressionService with escalating quality (0.8->0.2) and dimension (1280px->320px) fallback so proof uploads strictly stay under 500KB, throwing instead of silently uploading an oversized file. - Restore lib/api.ts and services/uploadService.ts from upstream/main (required by ImageCapture but missing on this branch); fix Windows encoding artifacts (BOM, mangled em-dashes) introduced during that pull. - Add unit tests for imageCompressionService, useImageCompressor, and ImageCapture (16 tests, Component -> Hook -> Service coverage). - Install browser-image-compression dependency. Closes SwiftChainn#293
|
@spiffamani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #293