fix(core): CWL to work with filenames with spaces #2187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigsterkr
commented
Jun 18, 2021
| kwargs={"rm_tmpdir": False, "move_outputs": "leave", "preserve_entire_environment": True} | ||
| ) | ||
| loading_context = LoadingContext(kwargs={"construct_tool_object": construct_tool_object}) | ||
| loading_context = LoadingContext(kwargs={"construct_tool_object": construct_tool_object, "relax_path_checks": True}) |
Contributor
Author
There was a problem hiding this comment.
@Panaetius should this be actually hardcoded here, or rather make it default True in LoadingContext?
Member
There was a problem hiding this comment.
This way is fine. LoadingContext is not one of our classes anyways 🙂
Panaetius
approved these changes
Jun 18, 2021
Member
Panaetius
left a comment
Panaetius
left a comment
There was a problem hiding this comment.
This is perfect, glad it actually was as easy as adding this flag 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2182