refactor: harmonize security context handling#4077
Merged
Conversation
securityContext content was defined in multiple different manifests. Their content being hard coded there made them unsuitable for modifications such as required for OpenShift deployment. This patch makes them all use the content coming from the values file since they were mostly all using the same values.
sgaist
force-pushed
the
refactor/security-context
branch
from
4ad8d0b to
b50a57d
Compare
olevski
approved these changes
Jul 3, 2025
olevski
added a commit
that referenced
this pull request
Jul 4, 2025
* chore: remove old search deployments and values (#4069) * fix: make the legacy services flag work (#4067) * feat: upgrade ui to 4.2.0 (#4075) * chore: simplify ui config for openshift (#4065) * feat: upgrade amalthea to 0.20.0 (#4076) * refactor: harmonize security context handling (#4077) securityContext content was defined in multiple different manifests. Their content being hard coded there made them unsuitable for modifications such as required for OpenShift deployment. This patch makes them all use the content coming from the values file since they were mostly all using the same values. * chore: reconcile the two security contexts PRs (#4074) --------- Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> * refactor: move service account creation to own template (#4080) * feat: upgrade ui to 4.2.1 (#4082) --------- Co-authored-by: Renku Bot <renku@datascience.ch> Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> Co-authored-by: Chandrasekhar Ramakrishnan <ciyer@users.noreply.github.com>
rokroskar
pushed a commit
that referenced
this pull request
Jul 8, 2025
* chore: remove old search deployments and values (#4069) * fix: make the legacy services flag work (#4067) * feat: upgrade ui to 4.2.0 (#4075) * chore: simplify ui config for openshift (#4065) * feat: upgrade amalthea to 0.20.0 (#4076) * refactor: harmonize security context handling (#4077) securityContext content was defined in multiple different manifests. Their content being hard coded there made them unsuitable for modifications such as required for OpenShift deployment. This patch makes them all use the content coming from the values file since they were mostly all using the same values. * chore: reconcile the two security contexts PRs (#4074) --------- Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> * refactor: move service account creation to own template (#4080) * feat: upgrade ui to 4.2.1 (#4082) --------- Co-authored-by: Renku Bot <renku@datascience.ch> Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> Co-authored-by: Chandrasekhar Ramakrishnan <ciyer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This patch harmonizes the handling/configuration of the securityContext field through all the templates.
Its content was defined in multiple different manifests. Being hard coded there made them unsuitable for modifications such as required for OpenShift deployment.
They now all use the content coming from the values file since they were mostly all using the same values.