This repository was archived by the owner on Jan 19, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 209
Feat/add giverole command #1007
Closed
viniciusestevam
wants to merge
6
commits into
SwitchbladeBot:dev
from
viniciusestevam:feat/add-giverole-command
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3ed2530
wip: starting the feature
viniciusestevam 4d487d1
added role hierarchy
53544ba
fix some bugs
69f4a8a
fix code style
viniciusestevam 315f08d
promise handling with try/catch
8b2d75f
Merge branch 'dev' into feat/add-giverole-command
viniciusestevam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| const { Command, CommandError, Constants, SwitchbladeEmbed } = require('../../') | ||
|
|
||
| module.exports = class Giverole extends Command { | ||
| constructor (client) { | ||
| super(client, { | ||
| name: 'giverole', | ||
| category: 'moderation', | ||
| requirements: { guildOnly: true, botPermissions: ['MANAGE_ROLES'], permissions: ['MANAGE_ROLES'] }, | ||
| parameters: [{ | ||
| type: 'member', acceptBot: true, missingError: 'commands:giverole.missingUser' | ||
| }, { | ||
| type: 'role', full: true, missingError: 'errors:invalidRole' | ||
| }] | ||
| }) | ||
| } | ||
|
|
||
| async run ({ channel, member, author, t }, targetMember, role) { | ||
| const embed = new SwitchbladeEmbed(author) | ||
| try { | ||
| if (!member.hasPermission('ADMINISTRATOR', false, true, false)) { | ||
| if (member.highestRole.comparePositionTo(role) <= 0) throw new CommandError(t('commands:giverole.roleAboveAuthors')) | ||
| if (member.highestRole.comparePositionTo(targetMember.highestRole) <= 0) throw new CommandError(t('commands:giverole.roleBelow')) | ||
| } | ||
| await targetMember.addRole(role) | ||
| embed | ||
| .setTitle(t('commands:giverole.successTitle')) | ||
| .setDescription(`${targetMember} - \`${role.name}\``) | ||
| } catch (err) { | ||
| embed | ||
| .setColor(Constants.ERROR_COLOR) | ||
| .setTitle(t('commands:giverole.cantGiverole')) | ||
| .setDescription(`\`${err}\``) | ||
| } | ||
| channel.send(embed) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This verification process should be made before adding the role to the target member.
And the condition in line 22 is non-sense, you are comparing
member.highestRoleto itself:member.highestRole.comparePositionTo(member.highestRole)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shit, I just changed the variable names and forgot this one lol.