This repository was archived by the owner on Jan 19, 2025. It is now read-only.
Feat/add giverole command #1007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davipatury
suggested changes
Oct 11, 2019
src/commands/moderation/giverole.js
Outdated
|
|
||
| async run ({ channel, member, author, t }, targetMember, role) { | ||
| const embed = new SwitchbladeEmbed(author) | ||
| await targetMember.addRole(role).then(modifiedMember => { |
Member
There was a problem hiding this comment.
Whenever you use async/await, you don't have to use .then or .catch you can use the simple try/catch. Ex.:
try {
await targetMember.addRole(role)
// do other things
} catch (e) {
// handle error
}| if (!member.hasPermission('ADMINISTRATOR', false, true, false)) { | ||
| if (member.highestRole.comparePositionTo(role) <= 0) throw new CommandError(t('commands:giverole.roleAboveAuthors')) | ||
| if (member.highestRole.comparePositionTo(member.highestRole) <= 0) throw new CommandError(t('commands:giverole.roleBelow')) | ||
| } |
Member
There was a problem hiding this comment.
This verification process should be made before adding the role to the target member.
And the condition in line 22 is non-sense, you are comparing member.highestRole to itself: member.highestRole.comparePositionTo(member.highestRole)
Author
There was a problem hiding this comment.
Oh shit, I just changed the variable names and forgot this one lol.
Member
|
So, how's this going? |
Member
|
@davipatury re-review? |
moruzerinho6
added
scope: commands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1006