Skip to content

Check if the product is assigned to any of the excluded taxons instead of all of them#73

Merged
NoResponseMate merged 3 commits into
Sylius:mainfrom
GSadee:SYL-2785/change-condition-for-checking-taxons
Mar 14, 2023
Merged

Check if the product is assigned to any of the excluded taxons instead of all of them#73
NoResponseMate merged 3 commits into
Sylius:mainfrom
GSadee:SYL-2785/change-condition-for-checking-taxons

Conversation

@GSadee

@GSadee GSadee commented Mar 13, 2023

Copy link
Copy Markdown
Member

No description provided.

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Mar 13, 2023
@GSadee GSadee force-pushed the SYL-2785/change-condition-for-checking-taxons branch from 39a7d1a to 51624ba Compare March 13, 2023 13:00
Comment thread src/Application/Checker/ProductVariantLowestPriceDisplayChecker.php Outdated
@NoResponseMate NoResponseMate merged commit 4828c14 into Sylius:main Mar 14, 2023
@NoResponseMate

Copy link
Copy Markdown
Contributor

Thank you, @GSadee!

@GSadee GSadee deleted the SYL-2785/change-condition-for-checking-taxons branch March 15, 2023 05:38
Rafikooo referenced this pull request in Sylius/Sylius Mar 17, 2023
…west price according to the excluded taxons (GSadee)

This PR was merged into the 1.13 branch.

Discussion
----------



| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13|
| Bug fix?        | no                                                      |
| New feature?    |yes                                                       |
| BC breaks?      | no                                                      |
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | after https://github.com/Sylius/PriceHistoryPlugin/pull/73|
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

ef40b26 [Behat][PriceHistory] Adjust scenarios for displaying lowest price according to the excluded taxons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants