fix: surface CHRR rounding non-convergence through randomSampling - #687
Merged
Conversation
sampleCHRR computed info.mveConverged but never warned when the maximum-volume ellipsoid rounding failed to converge, and randomSampling called sampleCHRR with a single output, so the diagnostic was unreachable through the documented entry point: a user sampling via randomSampling(...,'method','chrr') got no signal that the samples might be poorly mixed. sampleCHRR now warns on non-convergence, and randomSampling returns the CHRR info as a third output.
Function test results291 tests 265 ✅ 1m 9s ⏱️ Results for commit 29e29f6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
sampleCHRRcomputedmveConvergedbut never warned when the maximum-volume ellipsoid rounding failed to converge, andrandomSamplingdiscarded it (single output), so sampling viarandomSampling(...,'method','chrr')gave no signal that the samples might be poorly mixed.sampleCHRRnow warns on non-convergence, andrandomSamplingreturns the CHRRinfoas a third output.tSampling.mthatinfois reachable throughrandomSampling.Instructions on merging this PR:
develop3as target branch, and will be resolved with a squash-merge.