fix: hostname validation accepts flexible IntoIterator - #12
Merged
Conversation
joelsa
approved these changes
Aug 7, 2026
| /// will error if the hostname returned by the Turnstile API does not match any of the | ||
| /// provided hostnames. | ||
| /// When it is None, the hostname is not verified. | ||
| /// To skip hostname verification, set it to `None::<&str>`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when you only know the URL of your page but need to extract the hostname, usage becomes utterly terrible:
This PR makes the
valid_hostnamesparameter more flexible (though at the cost of requiringNone::<&str>to skip instead of justNone, which might be good because it makes it more difficult to skip).With this PR it becomes