feat: harden organization community governance - #9
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 693531cfc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Support | `/SUPPORT.md` | root or `.github/` | Project-specific support channels may override. | | ||
| | Issue forms | `/.github/ISSUE_TEMPLATE/` | repository `/.github/ISSUE_TEMPLATE/` | Labels are repository-local, so defaults do not assign labels automatically. | | ||
| | Pull request template | `/.github/pull_request_template.md` | root, `docs/`, or `.github/` | A repository may provide multiple templates in the supported directories. | | ||
| | Organization profile | `/PROFILE/README.md` | not inherited | Rendered only on the organization profile. | |
There was a problem hiding this comment.
GitHub renders an organization profile README only when README.md is in the lowercase profile folder of the public .github repository (GitHub Docs). This new table blesses /PROFILE/README.md, and the updated project directory remains under that uppercase path, so the public directory added in this change will not appear on the organization Overview page on GitHub's case-sensitive paths; please move it to profile/README.md and update the references.
Useful? React with 👍 / 👎.
| continue; | ||
| } | ||
| const relative = decodeURIComponent(target.split("#", 1)[0]); | ||
| const resolved = path.resolve(path.dirname(path.resolve(root, file)), relative); |
There was a problem hiding this comment.
For valid GitHub Markdown links that start with /, such as [governance](/docs/GOVERNANCE.md), GitHub treats the path as relative to the repository root (GitHub Docs), but this path.resolve(..., relative) call treats it as an absolute filesystem path like /docs/GOVERNANCE.md. A PR adding one of these valid repo-root links will fail npm run validate with a missing-target error even when the file exists; handle leading / by resolving it beneath root.
Useful? React with 👍 / 👎.
1 participant
Summary
Frozen issues
Closes #1, #2, #3, #4, #5, #6, and #7.
Validation
npm test(4 passed)npm run validate