feat(tup): add tup, migrate manually-synced snippets from tup-ui - #559
Merged
Conversation
tup-ui's Django templates/snippets folder mixes two kinds of files: manually-synced copies of djangocms-snippet content (versioned here for reference only, per this repo's "Save Snippets" convention) and files actually loaded live via a snippet's "template" field. Migrate only the manually-synced snippets; the template-loaded ones stay in tup-ui since Core-CMS-Custom does not serve them.
wesleyboar
changed the title
Renamed per review feedback. Also removed embed-vislab-cal-content.html, embed-vislab-cal.html, embed-vislab-form.html, and iframe-styles-and-iframe-auto-height.html: my local tup-ui checkout had tup-ui#568 (a still-open draft PR) checked out instead of main, so those 4 files were pulled from that unmerged branch rather than tup-ui's actual current state. They'll come back in via the planned follow-up PR that syncs against open tup-ui PRs.
wesleyboar
changed the title
…l as manually synced Both are manually maintained (editable directly in their CMS admin snippet instance), not loaded via a "template" field as I'd assumed from the pinned-CDN-loader pattern. Confirmed by direct feedback; that pattern doesn't imply template loading on its own.
No other project uses a snippets subfolder, so drop the extra level.
wesleyboar
added a commit
that referenced
this pull request
Jul 31, 2026
## Overview Update `tup/html/` with every snippet change from a currently-open tup-ui PR. ## Related - requires #559 - migrates snippet changes from: - TACC/tup-ui#568 - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - TACC/tup-ui#566 ## Changes - **added** `embed-vislab-*.html` <sup>latest versions from:</sup> - TACC/tup-ui#568 - **updated** `css-ad-hoc-styles.html` <sup>hand-composed from:</sup> - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - **updated** `js-ad-hoc-scripts.html` <sup>hand-composed from:</sup> - TACC/tup-ui#535 - TACC/tup-ui#566 ## Testing 1. Compare `embed-vislab-*` files against the branch of TACC/tup-ui#568 to confirm content matches. 2. For `css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`, compare against each contributing PR's diff to confirm every intended change made it in.
This was referenced Jul 31, 2026
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
c-news.css, c-news--read.css, and c-news--list.css were general Core-Styles gaps found during tup-ui development, not tup-specific overrides, so they've moved to Core-CMS-Custom (TACC/Core-CMS-Custom#561) where other projects can find and use them. Loading moves to the ad-hoc CSS snippet (edited live in the CMS admin, already migrated to TACC/Core-CMS-Custom#559/#560) instead of assets_custom.html — no tup-ui code needs to load this CSS anymore.
wesleyboar
added a commit
that referenced
this pull request
Aug 3, 2026
## Overview Migrates CSS/JS assets (that `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html` load) from [TACC/tup-ui] to here. <details> [TACC/tup-ui]: https://github.com/TACC/ The snippets files were already migrated (#559, #560); this closes the loop so those snippets' `<link>`/`<script>` tags can point at this repo's CDN pins instead of tup-ui's. </details> ## Related - adds to #563 - integrates changes from: - TACC/tup-ui#566 - TACC/tup-ui#535 - TACC/tup-ui#562 > [!IMPORTANT] > **Follow-up:** Repoint `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`'s CDN URLs at this repo (not done in this PR). ## Changes - **added** `tup/css/ad-hoc/` (many files) - **added** `tup/js/ad-hoc.js` - **added** `tup/js/ad-hoc/manage-participants-field-required-attr.js` - **added** `tup/css/ad-hoc/hide-blog-list-back-link.css` (from TACC/tup-ui#562, open) - **added** `tup/css/ad-hoc/adjust-logo.css` (from TACC/tup-ui#535, open) - **updated** `navbar-width-horz-scrollbar.css` ## Testing 1. Confirm each file's content matches TACC/tup-ui's current copy exactly **except**: - `navbar-width-horz-scrollbar.css` matches TACC/tup-ui#535's branch - `adjust-logo.css` matches TACC/tup-ui#535's branch (doesn't exist on tup-ui `main`) - `hide-blog-list-back-link.css` matches TACC/tup-ui#562's branch (doesn't exist on tup-ui `main`) - `ad-hoc.js`/`manage-participants-field-required-attr.js` matches the commit already pinned in the live snippet, TACC/tup-ui@0c0beee5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new
tupproject for the main TACC site (tup-ui) and migrates its manually-synced djangocms-snippet copies here for version control.Related
apps/tup-cms/src/taccsite_cms/templates/snippets/folderChanges
tup/html/with 11 snippet files copied as-is from tup-ui'smainbranchREADME.mdto include TACCTesting
git loghistory in tup-ui to confirm it matches the last "save" commit.Notes
css-js-staff-profile.html,redirect.html,news/open-external-post.htmlloaded directly via a snippet's "template" field; confirmed via{{html}}context-variable usage and an explicit doc comment for the firsta-legend-key-to-the-icons.htmlandcss-js-staff-profile.mdare reference/documentation files, not djangocms-snippet content.