Conversation
…ates to overview, common capabilities list and major component list.
…t section at the end now.
taoteg
commented
Oct 12, 2023
wesleyboar
requested changes
Oct 13, 2023
Remove extraneous dashes. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Missing capitalization. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Missing period in `e.g.`, capitalization of Layer. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Various syntax tweaks to verbiage throughout. Changed form using ul/li to dl/dd/dt for better consistency in presentation.
Contributor
Author
|
@wesleyboar if you get a second, can you review it once more for correctness? |
Merged
wesleyboar
reviewed
Oct 13, 2023
Member
wesleyboar
left a comment
wesleyboar
left a comment
There was a problem hiding this comment.
A <dl> may not be nested directly within a <dl>.
Also, I tweaked some text for accuracy, like in "… Major Components" list.
* fix: indentation & wrapping `<dl>` `<dt>` `<dd>` * feat: more space between `<dd>` and `<dt>` By removing CSS that removed that space. Maybe removal looked good in much older styles. * fix: Web Portal description should be intro `<p>` * fix: "CEP Major Components" list
wesleyboar
approved these changes
Oct 16, 2023
wesleyboar
reviewed
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update to the verbiage and technologies described in the Portal Architecture Guide available in the Core-CMS.
Related
Changes
Testing
settings_local.pyto include:make buildmake startguides/portal_technology.htmlas the template and publish it.UI
Notes