Task/wi 33 fix dl usage#732
Merged
taoteg merged 4 commits intotask/WI-33from Oct 16, 2023
Merged
Conversation
By removing CSS that removed that space. Maybe removal looked good in much older styles.
wesleyboar
commented
Oct 13, 2023
Member
Author
There was a problem hiding this comment.
This looks messier than it is. Hide whitespace in the diff for an easier review.
I did not change text within paragraph-size text blocks. I fixed markup and changed indentation accordingly.
Before (Markup, Simplified Example)
<dl>
<dt>…</dt>
<dd>…</dd>
<dt>…</dt>
<dd>…</dd>
<dl>
<dt>…</dt>
<dd>…</dd>
<dt>…</dt>
<dt>…</dt>
<dd>…</dd>
</dl>
</dd>
<dt>…</dt>
<dd>…</dd>
</dl>
After (Markup, Simplified Example)
<dl>
<dt>…</dt>
<dd>…</dd>
<dt>…</dt>
<dd>
<p>....</p>
<dl>
<dt>…</dt>
<dd>…</dd>
<dt>…</dt>
<dt>…</dt>
<dd>…</dd>
</dl>
</dd>
<dt>…</dt>
<dd>…</dd>
</dl>
taoteg
approved these changes
Oct 16, 2023
taoteg
added a commit
that referenced
this pull request
Oct 16, 2023
* Initial set of changes for Portal Technology guide page. Includes updates to overview, common capabilities list and major component list. * More portal tech guide edits up to the Frontend My Dashboard section. * Updated the client-sider description. Completed up to the Enviropnment section at the end now. * The last edits to the Cor Portal Architecture guide page. Sans new image that is. * Update taccsite_cms/templates/guides/portal_technology.html Remove extraneous dashes. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> * Update taccsite_cms/templates/guides/portal_technology.html Missing capitalization. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> * Update taccsite_cms/templates/guides/portal_technology.html Missing period in `e.g.`, capitalization of Layer. Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> * Update portal_technology.html Various syntax tweaks to verbiage throughout. Changed form using ul/li to dl/dd/dt for better consistency in presentation. * Updated the My Dashboard section to use dl, dt, dd elements instead. * Missed an unclosed element tag. * Reverted one dt dd combo for Environment so it is properly formatted. * Added an entry about the My Account view. * Task/wi 33 fix dl usage (#732) * fix: indentation & wrapping `<dl>` `<dt>` `<dd>` * feat: more space between `<dd>` and `<dt>` By removing CSS that removed that space. Maybe removal looked good in much older styles. * fix: Web Portal description should be intro `<p>` * fix: "CEP Major Components" list --------- Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix markup indentation and usage. Tweak styles. Fixed "CEP Major Components" accuracy.
Related
Changes
<dl><dt><dd><dd>and<dt><p>Testing
UI
Very Tall Screenshot