Sub-Task/TUP-573 Add accessibility role(button) to dropdown a-tags#757
Merged
wesleyboar merged 1 commit intotask/tup-595-accessibilityfrom Dec 4, 2023
Merged
Conversation
R-Tomas-Gonzalez
added
priority ━
wesleyboar
approved these changes
Dec 4, 2023
This was referenced Dec 12, 2023
wesleyboar
added a commit
that referenced
this pull request
Dec 13, 2023
* adding role=button to a-tags (#757) * sub-task/tup-579 Added navbarDropdown id to a tag (#758) * fix: tup 662 nav dropdown id not unique (#762) * fix: tup-662 nav dropdown id * fix: tup-662 nav dropdown id, simpler solution * fix: tup-662 nav dropdown id, follow MDN a11y menu role docs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role --------- Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds role='button' to a-tags in dropdown.
Related
TUP-573
Changes
Adds role='button' to a-tags in dropdown.
Testing
UI