fix: tup 595 accessibility#761
Merged
wesleyboar merged 4 commits intomainfrom Dec 13, 2023
Merged
Conversation
This was referenced Dec 12, 2023
* fix: tup-662 nav dropdown id * fix: tup-662 nav dropdown id, simpler solution * fix: tup-662 nav dropdown id, follow MDN a11y menu role docs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role
wesleyboar
commented
Dec 13, 2023
Member
Author
wesleyboar
left a comment
wesleyboar
left a comment
There was a problem hiding this comment.
Merging. @wesleyboar code was approved by @R-Tomas-Gonzalez. And @R-Tomas-Gonzalez code was approved by @wesleyboar. I merely made the PR with all the code.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Dec 13, 2023
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Dec 15, 2023
* test(tup-cms): TUP-595 new cms image w/ a11y fixes https://github.com/TACC/Core-CMS/tree/task/tup-595-accessibility * sub-task/tup-580 Make footer button small 10px (#387) * sub-task/tup-580 Make footer button small 10px * original solution was wrong. let's not rely on <small>. instead, rely on the a class, <small> tags parent. * enhance: use existing core-styles var --------- Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> * sub-task/tup-575 Adds in new aria-describedby link attributes (#388) * adds in new aria-describedby link attributes Let's target all of the tags that have target=_blank and make them accessible. * Adjust comments * changes type of script. adds html markup. * fix: Core-CMS CMS navbar a11y TACC/Core-CMS#762 * feat(tup-cms): Core-CMS v4.3.0 - installs https://github.com/TACC/Core-CMS/releases/tag/v4.3.0 - to get TACC/Core-CMS#761 --------- Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Various accessibility fixes.
Related
Changes / Testing / UI