Skip to content

feat: TUP-553 redesign news article byline #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesleyboar merged 4 commits into from
Dec 14, 2023
Merged

feat: TUP-553 redesign news article byline #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe86d48
feat: TUP-553 hide byline prefix
wesleyboar Dec 13, 2023
fb0dde4
docs: TUP-553 simpler byline comments
wesleyboar Dec 13, 2023
0d9f9cc
feat: TUP-553 new byline layout
wesleyboar Dec 13, 2023
81962d9
feat: TUP-553 new byline layout, page vs list
wesleyboar Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified taccsite_cms/locale/en/LC_MESSAGES/django.mo
View file
Open in desktop
Binary file not shown.
6 changes: 0 additions & 6 deletions taccsite_cms/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ msgstr ""
"Users can't move a page without permissions to change the page. "
"Ensure user has \"Can edit\" permission."


#: djangocms-blog
#: templates/djangocms_blog/includes/blog_meta.html:6
msgid "by"
msgstr "by:"

#: djangocms-blog
#: cms_appconfig.py:39
msgid ""
Expand Down
11 changes: 5 additions & 6 deletions taccsite_cms/static/site_cms/css/src/_imports/components/django.cms.blog.app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,17 @@ Styleguide Components.DjangoCMS.Blog.App
/* Metadata */

/* To layout data */
.app-blog .attrs,
.app-blog .tags,
.app-blog .categories {
display: flex;
flex-direction: row;
gap: 1em;
}
.app-blog .attrs {
justify-content: space-between;
}
.app-blog .date {
order: -1


/* To always hide byline prefix */
.app-blog .byline > span {
display: none;
}

/* To conditionally hide tags & categories */
Expand Down
17 changes: 17 additions & 0 deletions taccsite_cms/static/site_cms/css/src/_imports/components/django.cms.blog.app.item.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,23 @@ Styleguide Components.DjangoCMS.Blog.App.Item



/* Metadata */

:--article-item .attrs {
display: flex;
flex-direction: row;
}
:--article-item .attrs {
justify-content: space-between;
}
:--article-item .date {
order: -1;
}





/* Visual */

:--article-item .blog-visual:empty {
Expand Down
14 changes: 14 additions & 0 deletions taccsite_cms/static/site_cms/css/src/_imports/components/django.cms.blog.app.page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,20 @@ Styleguide Components.DjangoCMS.Blog.App.Page



/* Metadata */

:--article-page .attrs {
display: flex;
flex-direction: column;
}
:--article-page .date {
order: -1;
}





/* Media & Content */

:--article-page :is(.blog-visual, .blog-content) {
Expand Down
4 changes: 2 additions & 2 deletions taccsite_cms/templates/djangocms_blog/includes/blog_meta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
{# TACC (add class so CSS can target this element): #}
<li class="byline">
{# /TACC #}
{# TACC (add <span> and &nbsp; so whitespace can be stripped): #}
<span>{% trans "by" %}</span>&nbsp;
{# TACC (add <span> so "by" can be styled): #}
<span>{% trans "by" %}</span>
{# /TACC #}
<a href="{% url 'djangocms_blog:posts-author' post.author.get_username %}">{% if post.author.get_full_name %}{{ post.author.get_full_name }}{% else %}{{ post.author }}{% endif %}</a>
</li>
Expand Down