Skip to content

fix: CMD-163 v3.10–v3.11 migration news layout (ECEP)#839

Merged
wesleyboar merged 4 commits intomainfrom
fix/cmd-163-ecep-news-layout
Jul 3, 2024
Merged

fix: CMD-163 v3.10–v3.11 migration news layout (ECEP)#839
wesleyboar merged 4 commits intomainfrom
fix/cmd-163-ecep-news-layout

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Jul 3, 2024

Overview

Fix layout on News for site that uses Core-Styles v0 (i.e. v3.10—v3.11 migration stylesheet).

Related

Changes

In v3.10—v3.11 migration stylesheet:

  • changed :is to :where when laying out byline (and date)

When v3.10—v3.11 migration styles are used:

  • added whitespace
  • changed markup to not isolate dates

Testing

  1. Set TACC_CORE_STYLES_VERSION to 0.
  2. Run/Create a CMS site with News.
  3. Create/have published article.
  4. Open http://localhost:8000/news/.
  5. Verify article in list:
    • has "by [user]" (notice the space after "by")
    • does not have "Published " before date
    • shows date as small text
  6. Open http://localhost:8000/news/your_article.
  7. Verify article page — if byline is hidden — shows date on left (under article title).

UI

Article List

before after
before after

Article Page

before
with visible hidden
after
with visible hidden
after
with byline hidden
before after after - hide byline

Use `:where` so clients can override wihtout excess specificity.
Only isolate date for styles v2 sites.
Add space when sites are not using latest styles.
@wesleyboar wesleyboar changed the title fix: CMD-163 ECEP news layout fix: CMD-163 v3.10–v3.11 migration news layout (ECEP) Jul 3, 2024
Styles v1 is irrelevant.

> # TACC CMS - Stylesheets - Migrations - v3.10 to v3.11
>
> This is a migration:
>
> - from v3.10 with **no** `TACC_CORE_STYLES_VERSION`
> - to v3.11 with `TACC_CORE_STYLES_VERSION = `**`2`**
>
> — taccsite_cms/static/site_cms/css/src/_migrations/v3-10_v3-11/README.md
@wesleyboar wesleyboar marked this pull request as ready for review July 3, 2024 21:20
@wesleyboar wesleyboar merged commit a27b41a into main Jul 3, 2024
@wesleyboar wesleyboar deleted the fix/cmd-163-ecep-news-layout branch July 3, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant