Add check if can be negative in equality - fix 2156598#219
Merged
srba merged 1 commit intoJul 2, 2026
Conversation
srba
approved these changes
Jul 2, 2026
srba
left a comment
srba
left a comment
Member
There was a problem hiding this comment.
Fixes the problem and it is consistent on MCC 26 reachability queries with the main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine assumed that place expressions are always non-negative and rewrites E == 0 to E <= 0, which is wrong when it contains subtractions:
https://bugs.launchpad.net/tapaal/+bug/2156598