Merged
Conversation
also address #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also address #17
Legend:
Smallest TV console height we have is 192, biggest handheld height we have is 384. Also there can be tons of windowed PC games that don't need aspect ratio correction but need different prescaling. So I excluded aspect ratio correction from the formula and tried to only deduce upscale factor from height alone.
So I divide 768 by height and then round the result down to be a multiple of 2, so 3 becomes 2, 5 becomes 4, etc. That way resolution below 192p goes 4x, which is most our handhelds. And 480p kinda footage remains 1x. And if Dolphin outputs something small, we have manual override.
All the rest is just refactoring so should be functionally identical, but needs testing.