Skip to content

fix(bettergi): #523 评审修复——切号脚本恢复重做、日志监控交由 #510 - #1

Open
qiyinxi wants to merge 4 commits into
TCddddd:fix/bettergi-498-issuesfrom
qiyinxi:pr/523-review-fixes
Open

fix(bettergi): #523 评审修复——切号脚本恢复重做、日志监控交由 #510#1
qiyinxi wants to merge 4 commits into
TCddddd:fix/bettergi-498-issuesfrom
qiyinxi:pr/523-review-fixes

Conversation

@qiyinxi

@qiyinxi qiyinxi commented Sep 1, 2026

Copy link
Copy Markdown

对应 AUTO-MAS-Project#523 的评审意见,直接提到你的分支上,合并后 AUTO-MAS-Project#523 会自动带上这些改动。三个提交各自独立,可以只取一部分。

验证(独立 venv,Python 3.12,Windows):模拟脚本跑通首轮不删库 → 记录标记 → 次轮重建 → 脚本就绪后清标记 → 误删不删库五个阶段,BGI 目录树内无 MAS 残留文件;pytest tests --collect-only -q 退出码 0;全量 tests 360 passed / 1 failed,失败项在 dev 上同样失败;改动文件 ruff check 通过。

另外 AUTO-MAS-Project#523 正文的 Closes #498 建议改成「关联 AUTO-MAS-Project#498」,清单里还有未处理项。

TCddddd and others added 4 commits September 1, 2026 22:34
…t#498)

- log monitor: pass callable log path so daily-rolling logs switch across midnight
- ScriptConfig: remove runtime slot after config session (final_task & on_crash)
- account_switch: only rebuild repo when previous checkout also failed
- open BetterGI with elevated only when MAS itself is not elevated
- step report: pick success run when retries happened (no duplicated 1/N)
- notify: add one day when step duration crosses midnight
- frontend/backend: unify enabled default for custom groups
AUTO-MAS-Project#510 已把 LogMonitor 入参统一为 resolver、将 _build_log_path 改名为
_resolve_log_file_path 并删除 script_log_path,还补了切换后刷新时间戳基准
日期的修复;这两处 hunk 与其冲突且缺该修复,先合入时会引用不存在的方法。

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- 标记改为在切号结束、BGI 确已启动并退出后,脚本仍缺失时才写入,并放到
  MAS 自有的 data/{script_id}/ 目录,不再进 BGI 的 User/JsScript
- 是否 rmtree 仓库改在杀掉旧 BGI 进程之后单独判断,首次启用与用户误删
  都不会在第一轮删除整个 Repos/bettergi-scripts-list
- 调度台文案与 docstring 同步为新流程
- 分步报告无成功轮时回退取最后一个能解析出步骤的轮次,避免整块省略
- notify._step_duration 按 ruff format 排版

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants