[Feat/#2] 페이지 라우팅 구조 및 공통 레이아웃 설정#3
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Walkthrough공통 레이아웃 컴포넌트 Changes레이아웃 및 라우팅 구조 도입
Estimated code review effort: 2 (Simple) | ~15 minutes Related issues: Suggested labels: enable-auto-review Suggested reviewers: 없음(정보 부족) Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
src/components/common/ScreenContainer.tsx (1)
27-29: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueclassName 병합에
clsx/tailwind-merge사용 고려현재 템플릿 리터럴로 className을 이어붙이고 있어, 외부에서 전달된
className이flex-1 px-4 py-[34px]등과 충돌(예: padding 재정의)할 경우 우선순위가 예측하기 어려울 수 있습니다.clsx+tailwind-merge(또는 nativewind의cn유틸)를 사용하면 이런 충돌을 안전하게 해결할 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/common/ScreenContainer.tsx` around lines 27 - 29, The className composition in ScreenContainer should avoid raw template-string concatenation because it can produce unstable Tailwind precedence when callers pass conflicting styles. Update the View in ScreenContainer to build classes through clsx plus tailwind-merge, or the existing cn utility if available, so VARIANT_BG[variant], the base layout classes, and the optional className are merged safely. Use the ScreenContainer component and its View className expression as the main fix point.app/(tabs)/_layout.tsx (2)
25-33: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick wincalendar/statistics/settings 탭에 아이콘 누락.
index탭에만tabBarIcon이 지정되어 있고 나머지 탭에는 아이콘이 없습니다.IconSymbol의MAPPING에도"house.fill"만 존재하는 것으로 보아, 후속 작업에서 각 탭에 맞는 아이콘 매핑 추가가 필요합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/`(tabs)/_layout.tsx around lines 25 - 33, The calendar, statistics, and settings tabs are missing tabBarIcon definitions in the Tabs.Screen configuration, while index is the only tab using IconSymbol. Update the tab options in the _layout Tabs setup so each of these screens also passes a tabBarIcon using IconSymbol, and add the corresponding icon names to IconSymbol’s MAPPING so the new tab icons resolve correctly.
9-10: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value임시 주석 정리 필요.
"임시 - 공통 컴포넌트 구현 후 교체 예정" 주석이 남아있는데, 이번 PR에서 이미 공통 레이아웃(ScreenContainer)이 구현되었습니다. 해당 주석이 여전히 유효한지 확인 후 정리해주세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/`(tabs)/_layout.tsx around lines 9 - 10, The temporary comment in the tab layout is now stale because the shared layout has already been implemented. Review the comments in the _layout.tsx tab routing setup and remove or rewrite the “임시 - 공통 컴포넌트 구현 후 교체 예정” note so it matches the current ScreenContainer-based implementation and no longer implies pending replacement.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/`(tabs)/_layout.tsx:
- Around line 25-33: The calendar, statistics, and settings tabs are missing
tabBarIcon definitions in the Tabs.Screen configuration, while index is the only
tab using IconSymbol. Update the tab options in the _layout Tabs setup so each
of these screens also passes a tabBarIcon using IconSymbol, and add the
corresponding icon names to IconSymbol’s MAPPING so the new tab icons resolve
correctly.
- Around line 9-10: The temporary comment in the tab layout is now stale because
the shared layout has already been implemented. Review the comments in the
_layout.tsx tab routing setup and remove or rewrite the “임시 - 공통 컴포넌트 구현 후 교체
예정” note so it matches the current ScreenContainer-based implementation and no
longer implies pending replacement.
In `@src/components/common/ScreenContainer.tsx`:
- Around line 27-29: The className composition in ScreenContainer should avoid
raw template-string concatenation because it can produce unstable Tailwind
precedence when callers pass conflicting styles. Update the View in
ScreenContainer to build classes through clsx plus tailwind-merge, or the
existing cn utility if available, so VARIANT_BG[variant], the base layout
classes, and the optional className are merged safely. Use the ScreenContainer
component and its View className expression as the main fix point.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 811cb3ac-d9d8-43e6-ab54-ea8650eb2d0c
⛔ Files ignored due to path filters (4)
assets/images/partial-react-logo.pngis excluded by!**/*.png,!**/assets/**assets/images/react-logo.pngis excluded by!**/*.png,!**/assets/**assets/images/react-logo@2x.pngis excluded by!**/*.png,!**/assets/**assets/images/react-logo@3x.pngis excluded by!**/*.png,!**/assets/**
📒 Files selected for processing (28)
app/(auth)/login.tsxapp/(auth)/signup.tsxapp/(stacks)/alarm/index.tsxapp/(stacks)/category/add.tsxapp/(stacks)/category/edit.tsxapp/(stacks)/diary/[id].tsxapp/(stacks)/diary/write.tsxapp/(stacks)/schedule/index.tsxapp/(stacks)/statistic/detail.tsxapp/(stacks)/statistic/incomplete.tsxapp/(tabs)/_layout.tsxapp/(tabs)/calendar.tsxapp/(tabs)/explore.tsxapp/(tabs)/index.tsxapp/(tabs)/settings.tsxapp/(tabs)/statistics.tsxapp/_layout.tsxapp/modal.tsxcomponents/external-link.tsxcomponents/hello-wave.tsxcomponents/parallax-scroll-view.tsxcomponents/themed-text.tsxcomponents/themed-view.tsxcomponents/ui/collapsible.tsxcomponents/ui/icon-symbol.tsxsrc/components/common/ScreenContainer.tsxsrc/components/common/index.tstailwind.config.js
💤 Files with no reviewable changes (9)
- components/themed-text.tsx
- components/hello-wave.tsx
- components/external-link.tsx
- components/parallax-scroll-view.tsx
- components/ui/collapsible.tsx
- app/(tabs)/explore.tsx
- components/themed-view.tsx
- app/modal.tsx
- components/ui/icon-symbol.tsx
yewon20804
reviewed
Jul 4, 2026
yewon20804
left a comment
yewon20804
left a comment
Contributor
There was a problem hiding this comment.
페이지 라우팅이랑 전체 구조 잡아줘서 고마워융-! 짱짱👍👍👍
yewon20804
approved these changes
Jul 4, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
(Closes 키워드가 있어야 PR이 머지되었을 때 이슈가 자동으로 닫힌다)
📌 PR 유형
어떤 변경 사항이 있나요?
📌 PR 요약
ScreenContainer)를 추가📌 작업 세부 내용
'variant' prop으로 '(tabs)'/'(auth)'는 'bg-bg', '(stacks)'는 'bg-gray-0`'배경 구분
📸 스크린샷 (선택)
🔗 참고 자료