chore: drop the required review count on main to 0 - #2
Merged
Conversation
A 1-approval requirement on a solo-maintained repo means every change needs `gh pr merge --admin`, which trains you to reach for the override reflexively -- that erodes the protection more than lowering the count does. The rules still doing real work stay: PRs are still required, status checks must pass, commits must be signed, and main cannot be force-pushed or deleted. Code-owner review and thread resolution remain on, so they take effect the moment a second maintainer exists. Applied live as ruleset 20350835; this commit keeps the file in the repo matching what GitHub is enforcing.
TGPSKI
added a commit
that referenced
this pull request
Aug 4, 2026
fork-only already carried RepositoryRole/5/always; main-ci, main-reviews and release-tags-immutable did not. leather and skeptic carry it on all four, and conceit now does too — this brings vanity in line. Without it, main-reviews leans on required_approving_review_count: 0 to stay workable on a solo repo (see #2), which weakens the rule for everyone rather than exempting the one person who needs the exemption. The bypass is the narrower tool. release-tags-immutable is the one that actually bites: re-cutting a tag you just found a defect in is impossible without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the committed ruleset in sync with what GitHub is actually enforcing
(ruleset
20350835, applied live).A 1-approval requirement on a solo-maintained repo means every change needs
gh pr merge --admin. Reaching for the override reflexively erodes theprotection more than lowering the count does.
Still enforced on
main:Test (3.10),Test (3.14))require_code_owner_reviewandrequired_review_thread_resolutionstay on, sothey take effect the moment there is a second maintainer.