Skip to content

Check if Activity is in picture-in-picture mode#89

Merged
MattiasBuelens merged 14 commits intodevelopfrom
bugfix/activity-pip
Mar 23, 2026
Merged

Check if Activity is in picture-in-picture mode#89
MattiasBuelens merged 14 commits intodevelopfrom
bugfix/activity-pip

Conversation

@MattiasBuelens
Copy link
Collaborator

Right now, Player.pictureInPicture only returns true when THEOplayer's PiPManager.isInPiP() is true. However, if the activity has entered picture-in-picture mode without using the THEOplayer API, then the UI won't update correctly.

This fixes that by also checking for Activity.isInPictureInPictureMode in Player.pictureInPicture.

@MattiasBuelens MattiasBuelens requested a review from ceyhun-o March 20, 2026 12:20
@MattiasBuelens MattiasBuelens added the bug Something isn't working label Mar 20, 2026
@MattiasBuelens MattiasBuelens merged commit 98a7203 into develop Mar 23, 2026
1 check passed
@MattiasBuelens MattiasBuelens deleted the bugfix/activity-pip branch March 23, 2026 16:33
This was referenced Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants