Add ordered params support and fix url encoding for Uplynk signature validation#109
Add ordered params support and fix url encoding for Uplynk signature validation#109rubenglobant wants to merge 2 commits intoTHEOplayer:mainfrom
Conversation
There was a problem hiding this comment.
This change aligns pingParameters with the android implementation
The orderedPreplayParameters is indeed necessary to maintain the order of the keys and values.
This looks good to me ✅
|
@rubenglobant We maintain a changelog file at the root of the repository for public changes that are worth logging. Since adding |
|
Added the changelog entry |
|
@rubenglobant Since it's a repo containing multiple connectors, we specify the title of the connector before the change. In this case it should be |
|
@rubenglobant Also make sure to add |
|
Hi @rubenglobant, This PR as is is incomplete without proper changelog entries and documentation updates, and therefore does not meet our standards to merge. Since we also do not have access to make changes to your fork, in order to speed up the process I am closing this PR in favor of #110, where I have cherry-picked your changes. Once again, thank you for your contribution. |
Description
This PR addresses critical issues with Uplynk signature validation caused by parameter handling.
Changes
orderedPreplayParameterstoUplynkSSAIConfiguration. This assumes the caller provides the correct order required by the signature, preventingDictionaryfrom shuffling them.npa%3D1asnpa%253D1) and handles commas incidcorrectly.pingParametersnow returns an empty string when.noPingis configured, preventing injection of unsigned parameters.Motivation
Without these fixes, valid signatures generated server-side or via KMM logic were failing validation due to reordering or double-decoding of special characters.