fix(build-logic): resolve the Gradle wrapper by absolute path - #41
Merged
Conversation
Every shell-out passed the bare script name, which on Windows is not found: the current directory is not on PATH, so `Exec` fails with "'gradlew.bat' is not recognized" regardless of workingDir. releaseValidateBuild died there, taking the whole local release with it; the per-target fan-out and the build-logic publish had the same latent bug. CI never saw it because "./gradlew" resolves fine on Linux. magicUtilsGradleWrapper(rootDir) now returns the absolute path, which behaves identically on both platforms. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Bt7RgUQ8kNZGgF4DBBUpj
THEROER
added a commit
that referenced
this pull request
Jul 31, 2026
fix(build-logic): resolve the Gradle wrapper by absolute path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releaseValidateBuild, the per-target fan-out and the build-logic publish all shelled out to the bare wrapper name. On Windows that is not resolvable — the current directory is not on PATH, soExecfails with'gradlew.bat' is not recognizedno matter whatworkingDiris set to. This blocks./gradlew releaseentirely from a Windows machine; CI never saw it because./gradlewresolves fine on Linux.magicUtilsGradleWrapper(rootDir)returns the absolute path instead, which behaves the same on both platforms.Found while running the 1.27.4 release:
releasefailed at:releaseValidateBuildwith exit 1.