Skip to content

Fix postgres incompatibility#1079

Merged
samuelwei merged 4 commits intodevelopfrom
1078-postgres-incompatibility
May 15, 2024
Merged

Fix postgres incompatibility#1079
samuelwei merged 4 commits intodevelopfrom
1078-postgres-incompatibility

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented May 15, 2024

Fixes #1078

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fixes postgres incompatibility issues
    • Migration issues
    • Database queries case-sensitive
    • Add postgres phpunit tests to CI

@samuelwei samuelwei linked an issue May 15, 2024 that may be closed by this pull request
@samuelwei samuelwei mentioned this pull request May 15, 2024
6 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 98.48485% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.86%. Comparing base (8e17b73) to head (6acf0dd).
Report is 6 commits behind head on develop.

Files Patch % Lines
app/Auth/Local/LocalProvider.php 87.50% 1 Missing ⚠️
...pp/Http/Controllers/api/v1/RecordingController.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1079      +/-   ##
=============================================
+ Coverage      95.81%   95.86%   +0.04%     
- Complexity      1232     1247      +15     
=============================================
  Files            190      191       +1     
  Lines           4210     4258      +48     
=============================================
+ Hits            4034     4082      +48     
  Misses           176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit 0cf08e7 into develop May 15, 2024
@samuelwei samuelwei deleted the 1078-postgres-incompatibility branch May 15, 2024 08:38
@samuelwei samuelwei restored the 1078-postgres-incompatibility branch May 15, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postgres incompatibility

1 participant