Conversation
…or-application-settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #989 +/- ##
=============================================
+ Coverage 95.65% 95.83% +0.17%
- Complexity 1252 1288 +36
=============================================
Files 193 198 +5
Lines 4282 4413 +131
=============================================
+ Hits 4096 4229 +133
+ Misses 186 184 -2 ☔ View full report in Codecov by Sentry. |
|
As discussed, please consider fixing/adding Postgres compatibility by changing (introduced in - $table->string('id')->index()->unique();
+ $table->string('id')->primary();ideally this should be fixed in said migration, too. |
…or-application-settings # Conflicts: # docs/UPGRADE.md
780c41e to
5d18469
Compare
These issues will be fixed first in #1079 and later adjusted to this PR |
…or-application-settings # Conflicts: # composer.lock # database/migrations/v1/2020_12_17_113850_simplify_server_status.php
…or-application-settings # Conflicts: # .env.ci # CHANGELOG.md
danielmachill
left a comment
There was a problem hiding this comment.
localisation, tests and upgrade documentation not yet reviewed
…or-application-settings # Conflicts: # composer.lock # resources/views/application.blade.php
Fixes #985
Type (Highlight the corresponding type)
Checklist
Changes
Other information