Skip to content

Refactor application settings#989

Merged
samuelwei merged 31 commits intodevelopfrom
985-refactor-application-settings
May 22, 2024
Merged

Refactor application settings#989
samuelwei merged 31 commits intodevelopfrom
985-refactor-application-settings

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Apr 8, 2024

Fixes #985

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Drop old global application settings storage
  • Add new global application settings storage
  • Add database upgrade command for v2/v3 to v4
  • Adjust docs
  • Cleanup .env

Other information

@samuelwei samuelwei linked an issue Apr 8, 2024 that may be closed by this pull request
@samuelwei samuelwei marked this pull request as ready for review April 9, 2024 09:30
@samuelwei samuelwei requested a review from Sabr1n4W April 9, 2024 09:30
@samuelwei samuelwei added this to the v4.0 milestone Apr 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (200cc55) to head (a789981).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #989      +/-   ##
=============================================
+ Coverage      95.65%   95.83%   +0.17%     
- Complexity      1252     1288      +36     
=============================================
  Files            193      198       +5     
  Lines           4282     4413     +131     
=============================================
+ Hits            4096     4229     +133     
+ Misses           186      184       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danimo
Copy link
Copy Markdown

danimo commented May 8, 2024

As discussed, please consider fixing/adding Postgres compatibility by changing (introduced in 2022_09_27_193354_create_sessions_table.php):

-            $table->string('id')->index()->unique();
+            $table->string('id')->primary();

ideally this should be fixed in said migration, too.

@samuelwei samuelwei force-pushed the 985-refactor-application-settings branch from 780c41e to 5d18469 Compare May 15, 2024 07:44
@samuelwei samuelwei marked this pull request as draft May 15, 2024 07:44
@samuelwei
Copy link
Copy Markdown
Collaborator Author

As discussed, please consider fixing/adding Postgres compatibility by changing (introduced in 2022_09_27_193354_create_sessions_table.php):

-            $table->string('id')->index()->unique();
+            $table->string('id')->primary();

ideally this should be fixed in said migration, too.

These issues will be fixed first in #1079 and later adjusted to this PR

…or-application-settings

# Conflicts:
#	composer.lock
#	database/migrations/v1/2020_12_17_113850_simplify_server_status.php
@samuelwei samuelwei marked this pull request as ready for review May 15, 2024 08:53
@samuelwei samuelwei requested review from danielmachill and removed request for Sabr1n4W May 15, 2024 08:53
samuelwei added 2 commits May 15, 2024 16:54
…or-application-settings

# Conflicts:
#	.env.ci
#	CHANGELOG.md
Copy link
Copy Markdown
Collaborator

@danielmachill danielmachill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localisation, tests and upgrade documentation not yet reviewed

Comment thread CHANGELOG.md Outdated
Comment thread app/Console/Commands/CleanupRoomsCommand.php Outdated
Comment thread app/Http/Requests/UpdateSetting.php Outdated
Comment thread app/Http/Requests/UpdateSetting.php Outdated
Comment thread config/settings.php
Comment thread lang/fr/settings.php
Comment thread storage/settings.json Outdated
Comment thread docs/docs/administration/05-upgrade.md Outdated
Comment thread docs/docs/administration/05-upgrade.md
@samuelwei samuelwei merged commit 87a7ab0 into develop May 22, 2024
@samuelwei samuelwei deleted the 985-refactor-application-settings branch May 22, 2024 13:21
Copy link
Copy Markdown
Collaborator

@danielmachill danielmachill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor application settings

3 participants