Fix error handling inconsistencies in dialogs#1444
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1444 +/- ##
==========================================
Coverage 95.34% 95.34%
Complexity 1323 1323
==========================================
Files 203 203
Lines 4579 4579
==========================================
Hits 4366 4366
Misses 213 213 ☔ View full report in Codecov by Sentry. |
PILOS
|
||||||||||||||||||||||||||||
| Project |
PILOS
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 03m 07s |
| Commit |
|
| Committer | Samuel Weirich |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
46
|
| View all changes introduced in this branch ↗︎ | |
Sabr1n4W
approved these changes
Oct 1, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type (Highlight the corresponding type)
Checklist
Changes
Other information
Dialogs are no longer closed for non-404 errors. This allows the user to retry in case of a server error, etc.