Skip to content

Fix error handling inconsistencies in dialogs#1444

Merged
samuelwei merged 4 commits intodevelopfrom
fix-inconsistent-dialog-closing
Oct 1, 2024
Merged

Fix error handling inconsistencies in dialogs#1444
samuelwei merged 4 commits intodevelopfrom
fix-inconsistent-dialog-closing

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Sep 27, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fix error handling inconsistencies in dialogs

Other information

Dialogs are no longer closed for non-404 errors. This allows the user to retry in case of a server error, etc.

@samuelwei samuelwei requested a review from Sabr1n4W September 27, 2024 15:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (a92f40f) to head (476475b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1444   +/-   ##
==========================================
  Coverage      95.34%   95.34%           
  Complexity      1323     1323           
==========================================
  Files            203      203           
  Lines           4579     4579           
==========================================
  Hits            4366     4366           
  Misses           213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Sep 27, 2024

PILOS    Run #760

Run Properties:  status check passed Passed #760  •  git commit 17668db337: Fix error handling inconsistencies in dialogs (#1444)
Project PILOS
Branch Review develop
Run status status check passed Passed #760
Run duration 03m 07s
Commit git commit 17668db337: Fix error handling inconsistencies in dialogs (#1444)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

@samuelwei samuelwei added the bug Something isn't working label Oct 1, 2024
@samuelwei samuelwei added this to the v4.1 milestone Oct 1, 2024
@samuelwei samuelwei merged commit 17668db into develop Oct 1, 2024
@samuelwei samuelwei deleted the fix-inconsistent-dialog-closing branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants