Skip to content

Don't close create room dialog on errors#1704

Merged
samuelwei merged 2 commits intodevelopfrom
fix-keep-create-room-dialog-open-on-errors
Dec 13, 2024
Merged

Don't close create room dialog on errors#1704
samuelwei merged 2 commits intodevelopfrom
fix-keep-create-room-dialog-open-on-errors

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Dec 13, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe): UX

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • The Create Room dialog will no longer close on errors that are not specifically handled (e.g.form validation errors). This allows the user to try again in the event of a server error etc.

Other information

Similar to #1444

@samuelwei samuelwei marked this pull request as ready for review December 13, 2024 10:06
@samuelwei samuelwei requested a review from Sabr1n4W December 13, 2024 10:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (8605c33) to head (ba4ec79).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1704   +/-   ##
==========================================
  Coverage      81.05%   81.05%           
  Complexity      1340     1340           
==========================================
  Files            361      361           
  Lines           9223     9223           
  Branches         851      851           
==========================================
  Hits            7476     7476           
  Misses          1747     1747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Dec 13, 2024

PILOS    Run #1425

Run Properties:  status check passed Passed #1425  •  git commit 28d4534dbd: Don't close create room dialog on errors (#1704)
Project PILOS
Branch Review develop
Run status status check passed Passed #1425
Run duration 04m 48s
Commit git commit 28d4534dbd: Don't close create room dialog on errors (#1704)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

@samuelwei samuelwei merged commit 28d4534 into develop Dec 13, 2024
@samuelwei samuelwei deleted the fix-keep-create-room-dialog-open-on-errors branch March 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants