Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
============================================
+ Coverage 95.10% 95.49% +0.38%
Complexity 1016 1016
============================================
Files 274 171 -103
Lines 6501 3615 -2886
Branches 528 0 -528
============================================
- Hits 6183 3452 -2731
+ Misses 304 163 -141
+ Partials 14 0 -14 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@Sabr1n4W Please checkout this code, build production code and manually test the whole app using the production code. We might not have time to refactor the tests, and it might not make sence due to the ongoing dev. of PILOS v3. |
samuelwei
added a commit
that referenced
this pull request
Dec 13, 2023
Replace awesome-mask with maska, Replace vue-swatches with own component, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop fileupload
samuelwei
added a commit
that referenced
this pull request
Dec 13, 2023
Replace awesome-mask with maska, Replace vue-swatches with own component, Add audio notification, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop file upload
samuelwei
added a commit
that referenced
this pull request
Dec 13, 2023
samuelwei
added a commit
that referenced
this pull request
Dec 18, 2023
* Cherry-pick changes from #743 Replace awesome-mask with maska, Replace vue-swatches with own component, Add audio notification, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop file upload, vue-i18n * Add test for ColorSelect and audio playback * Refactor code (slots, templates) * Refactor beforeEach vue-router, loading and i18n * Fix tests * Update docs
# Conflicts: # package-lock.json # package.json # resources/js/components/LocaleSelector.vue # resources/js/components/Permissions/Can.vue # resources/js/components/Permissions/Cannot.vue # resources/js/components/Room/HistoryComponent.vue # resources/js/i18n.js # resources/js/router.js # resources/js/stores/auth.js # resources/js/stores/loading.js # resources/js/stores/locale.js # resources/js/views/PasswordReset.vue # resources/js/views/rooms/View.vue # resources/js/views/settings/Application.vue # resources/js/views/settings/roomTypes/View.vue # resources/sass/app/_color-select.scss # resources/sass/app/app.scss
# Conflicts: # resources/js/stores/auth.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially solves #343
Type (Highlight the corresponding type)
Checklist
Changes
Other information
Vue 2 will reach End of Life (EOL) on December 31st, 2023.
After that date, Vue 2 will no longer receive updates, including security and browser compatibility fixes.
We should therefore solve this issue ASAP.
The refactoring for the changeover to Vue 3 will be performed later.