Skip to content

Vue 3#743

Merged
samuelwei merged 30 commits intomasterfrom
vue-3
Dec 19, 2023
Merged

Vue 3#743
samuelwei merged 30 commits intomasterfrom
vue-3

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Dec 11, 2023

Partially solves #343

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks only backend
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not: Frontend tests not working anymore due to Vue 3
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Migrate to Vue 3 using @vue/compat
  • Refactor code (slots, templates)
  • Replace awesome-mask with maska
  • Update tiptap, vue-cropperjs, vue-i18n, vue-router, vue-multiselect
  • Replace vue-swatches with own component
  • Remove vue-frag
  • Update eslint rule set

Other information

Vue 2 will reach End of Life (EOL) on December 31st, 2023.
After that date, Vue 2 will no longer receive updates, including security and browser compatibility fixes.
We should therefore solve this issue ASAP.

The refactoring for the changeover to Vue 3 will be performed later.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (641595c) 95.10% compared to head (ee958ab) 95.49%.

❗ Current head ee958ab differs from pull request most recent head 01de645. Consider uploading reports for the commit 01de645 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
+ Coverage     95.10%   95.49%   +0.38%     
  Complexity     1016     1016              
============================================
  Files           274      171     -103     
  Lines          6501     3615    -2886     
  Branches        528        0     -528     
============================================
- Hits           6183     3452    -2731     
+ Misses          304      163     -141     
+ Partials         14        0      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei
Copy link
Copy Markdown
Collaborator Author

@Sabr1n4W Please checkout this code, build production code and manually test the whole app using the production code.
We need to publish a release of PILOS v2 before end of this year, due to EOL of Vue 2.

We might not have time to refactor the tests, and it might not make sence due to the ongoing dev. of PILOS v3.

samuelwei added a commit that referenced this pull request Dec 13, 2023
Replace awesome-mask with maska, Replace vue-swatches with own component, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop fileupload
samuelwei added a commit that referenced this pull request Dec 13, 2023
Replace awesome-mask with maska, Replace vue-swatches with own component, Add audio notification, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop file upload
@samuelwei samuelwei mentioned this pull request Dec 13, 2023
6 tasks
samuelwei added a commit that referenced this pull request Dec 13, 2023
samuelwei added a commit that referenced this pull request Dec 18, 2023
* Cherry-pick changes from #743

Replace awesome-mask with maska, Replace vue-swatches with own component, Add audio notification, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop file upload, vue-i18n

* Add test for ColorSelect and audio playback

* Refactor code (slots, templates)

* Refactor beforeEach vue-router, loading and i18n

* Fix tests

* Update docs
# Conflicts:
#	package-lock.json
#	package.json
#	resources/js/components/LocaleSelector.vue
#	resources/js/components/Permissions/Can.vue
#	resources/js/components/Permissions/Cannot.vue
#	resources/js/components/Room/HistoryComponent.vue
#	resources/js/i18n.js
#	resources/js/router.js
#	resources/js/stores/auth.js
#	resources/js/stores/loading.js
#	resources/js/stores/locale.js
#	resources/js/views/PasswordReset.vue
#	resources/js/views/rooms/View.vue
#	resources/js/views/settings/Application.vue
#	resources/js/views/settings/roomTypes/View.vue
#	resources/sass/app/_color-select.scss
#	resources/sass/app/app.scss
# Conflicts:
#	resources/js/stores/auth.js
@samuelwei samuelwei merged commit 2514664 into master Dec 19, 2023
@samuelwei samuelwei deleted the vue-3 branch January 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant