Skip to content

Refactor UI#747

Merged
samuelwei merged 21 commits intomasterfrom
refactor-ui
Dec 18, 2023
Merged

Refactor UI#747
samuelwei merged 21 commits intomasterfrom
refactor-ui

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Dec 13, 2023

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current master branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Replace awesome-mask with maska
  • Replace vue-swatches with own component
  • Refactor i18n
  • Add audio notification
  • Add global event emitter / pubsub (mitt)
  • Refactor pagination
  • Fix drag'n dop file upload
  • Refactor code (slots, templates)
  • Renamed env option VITE_DEFAULT_LOCALE to DEFAULT_LOCALE (VITE_DEFAULT_LOCALE deprecated)
  • Renamed env option VITE_AVAILABLE_LOCALES to ENABLED_LOCALES (VITE_AVAILABLE_LOCALES deprecated)

Other information

This PR is cherry-picking changes from #743 that can be used with Vue 2. This way we can test these changes isolated from the upcoming vue 3 changes and add frontend software tests.

Replace awesome-mask with maska, Replace vue-swatches with own component, Add audio notification, Add global event emitter / pubsub (mitt), Refactor pagination, Fix drag'n dop file upload
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8df5f1b) 94.71% compared to head (fa98071) 95.10%.

❗ Current head fa98071 differs from pull request most recent head b91e70f. Consider uploading reports for the commit b91e70f to get more accurate results

Files Patch % Lines
resources/js/components/Room/FileComponent.vue 75.00% 1 Missing ⚠️
resources/js/services/EventBus.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #747      +/-   ##
============================================
+ Coverage     94.71%   95.10%   +0.39%     
- Complexity     1007     1016       +9     
============================================
  Files           273      274       +1     
  Lines          6487     6501      +14     
  Branches        526      528       +2     
============================================
+ Hits           6144     6183      +39     
+ Misses          328      304      -24     
+ Partials         15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit 741f619 into master Dec 18, 2023
@samuelwei samuelwei deleted the refactor-ui branch March 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant