fix(opd): pin teacher scoring temperature to 1.0 - #2319
Open
kkyyxhll wants to merge 1 commit into
Open
Conversation
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zhuzilin 辛苦review一下,非常感谢!
pr #2085 把opd的teacher payload的
temperature从0.0改成了args.rollout_temperature,但sgl内input的logp使用的都是1.0。因此会引起混淆。sgl 的 SGLANG_RETURN_ORIGINAL_LOGPROB和temperature只影响output的logp,input的logp不受影响(opd在这,max_new_tokens=0)
下面是实际测试结果,不同temperature并不影响input的各种logp。
起serve:
temperature=1.0的payload
结果(temperature=1.0)

修改payload的temperature=2.0

结果如下(temperature=2.0)
修改payload的temperature=0.5

结果如下(temperature=0.5)