[REF] Update code to Python 3 + PEP8 changes + remove deprecated scripts#245
Merged
DESm1th merged 63 commits intoTIGRLab:masterfrom Dec 27, 2019
Merged
[REF] Update code to Python 3 + PEP8 changes + remove deprecated scripts#245DESm1th merged 63 commits intoTIGRLab:masterfrom
DESm1th merged 63 commits intoTIGRLab:masterfrom
Conversation
test scripts that weren't snake case
josephmje
changed the title
Contributor
|
is this ok to merge now? |
Contributor
we'll wait for @jerdra 's review as well since this is a pretty huge PR |
|
Hi everyone,
Sorry for my delay on this – I’ve had a lot of loose ends to tie up today.
Jovanka
From: Michael Joseph [mailto:notifications@github.com]
Sent: Thursday, December 19, 2019 4:14 PM
To: TIGRLab/datman
Cc: Jovanka Skocic; Review requested
Subject: Re: [TIGRLab/datman] [REF] Update code to Python 3 + PEP8 changes + remove deprecated scripts (#245)
is this ok to merge now?
we'll wait for @jerdra<https://github.com/jerdra> 's review as well since this is a pretty huge PR
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#245?email_source=notifications&email_token=ANJMOJLLKGUMML25DJHTJWLQZPPYNA5CNFSM4J4CIMMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHLBSAQ#issuecomment-567679234>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANJMOJNTXJ5I5EZVE7MJST3QZPPYNANCNFSM4J4CIMMA>.
…______________________________________________________________________
This email has been scanned by the CAMH Email Security System.
______________________________________________________________________
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
AVIS DE CONFIDENTIALITÉ : Ce message électronique, ainsi que tout fichier qui y est joint, est reserve à l'usage exclusif du destinataire visé et peut contenir des renseignements confidentiels et privilégiés. Toute lecture, utilisation, divulgation ou distribution non autorisée est interdite. Si vous n'êtes pas le destinataire visé, veuillez en aviser l'expéditeur par retour de courriel et détruire toutes les copies du message original.
|
Contributor
Author
|
Might be good to wait till Monday to pull it in to the file system anyway, in case there are bugs to fix (there are always bugs to fix). |
Contributor
|
just cleaning up my review, it'll be ready in a bit |
jerdra
requested changes
Dec 23, 2019
Contributor
jerdra
left a comment
jerdra
left a comment
There was a problem hiding this comment.
Okkkk... so there's a lot, but many being minor.
Feel free to ignore some. A lot of these issues may be better dealt with in a separate script-wise refactoring PR rather than this one specifically.
Contributor
Author
|
@gabiherman, @josephmje, @jerdra - I think I've managed to finish all the requested changes. Sorry guys! |
Contributor
Author
|
.. Whoops, nvm. I just noticed the '23 hidden conversations'. Give me a few... |
Contributor
Author
|
Kk, now I'm done! |
Contributor
SO SORR, and sounds good! |
josephmje
approved these changes
Dec 23, 2019
Contributor
gabiherman
approved these changes
Dec 23, 2019
|
you guys are amazing!!
…________________________________
From: gabiherman [notifications@github.com]
Sent: December 23, 2019 4:52 PM
To: TIGRLab/datman
Cc: Jovanka Skocic; Review requested
Subject: Re: [TIGRLab/datman] [REF] Update code to Python 3 + PEP8 changes + remove deprecated scripts (#245)
@gabiherman approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#245?email_source=notifications&email_token=ANJMOJLBFKJ34U7SGSQZR33Q2EXKXA5CNFSM4J4CIMMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQDUL4Q#pullrequestreview-336020978>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANJMOJIYPU4WO4R67GUXPOTQ2EXKXANCNFSM4J4CIMMA>.
______________________________________________________________________
This email has been scanned by the CAMH Email Security System.
______________________________________________________________________
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
AVIS DE CONFIDENTIALITÉ : Ce message électronique, ainsi que tout fichier qui y est joint, est reserve à l'usage exclusif du destinataire visé et peut contenir des renseignements confidentiels et privilégiés. Toute lecture, utilisation, divulgation ou distribution non autorisée est interdite. Si vous n'êtes pas le destinataire visé, veuillez en aviser l'expéditeur par retour de courriel et détruire toutes les copies du message original.
|
DESm1th
added a commit
that referenced
this pull request
Dec 30, 2019
[FIX POST #245] - dm_task_files to pull all subjects instead of just checklisted ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.