Skip to content

[FIX POST #245] - dm_task_files to pull all subjects instead of just checklisted ones.#247

Merged
DESm1th merged 7 commits intoTIGRLab:masterfrom
jerdra:master
Dec 30, 2019
Merged

[FIX POST #245] - dm_task_files to pull all subjects instead of just checklisted ones.#247
DESm1th merged 7 commits intoTIGRLab:masterfrom
jerdra:master

Conversation

@jerdra
Copy link
Copy Markdown
Contributor

@jerdra jerdra commented Dec 18, 2019

Small tiny bug to fix so that task files are actively scraped even for unchecked files

Requires

@auto-assign auto-assign bot requested review from DESm1th and gabiherman December 18, 2019 20:59
@jerdra jerdra changed the title get all subjects instead of unchecklisted [Fix] - dm_task_files to pull all subjects instead of just checklisted ones. Dec 18, 2019
gabiherman
gabiherman previously approved these changes Dec 19, 2019
@jerdra
Copy link
Copy Markdown
Contributor Author

jerdra commented Dec 19, 2019

update: integrating additional changes to use dashboard mechanism since get_subjects will be deprecated in #245

@jerdra jerdra requested a review from gabiherman December 19, 2019 18:38
@jerdra jerdra changed the title [Fix] - dm_task_files to pull all subjects instead of just checklisted ones. [WIP] - dm_task_files to pull all subjects instead of just checklisted ones. Dec 19, 2019
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 20, 2019

Hello @jerdra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-30 16:48:52 UTC

@jerdra
Copy link
Copy Markdown
Contributor Author

jerdra commented Dec 20, 2019

We should merge this PR after #245.

@jerdra jerdra changed the title [WIP] - dm_task_files to pull all subjects instead of just checklisted ones. [FIX POST #245] - dm_task_files to pull all subjects instead of just checklisted ones. Dec 20, 2019
@DESm1th DESm1th merged commit f2ed330 into TIGRLab:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants