ci: enforce the README example count in validate-counts#64
Merged
Conversation
The job enforced skills/rules/templates/snippets but not examples, so the '20 examples' figure in the README could silently go stale when example 21 lands. Counts example directories by README.md presence (robust against stray dirs), mirrors the existing substring check, and was proven to fail on a deliberate mismatch before shipping. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate-countsjob enforced the skills/rules/templates/snippets counts in README.md but not the examples count, so the "20 examples" figure could silently go stale when example #21 lands (flagged in the README QoL pass, #63).examples/<dir>/directories that contain aREADME.md(robust against stray non-example dirs), mirroring how skills are counted bySKILL.mdpresence."{n} examples"must appear in README.md.Proven to fail: the check logic was run locally against the real README (pass, 20 counted) and against a README with "20 examples" edited to "19 examples" (fails with the expected error message).
🤖 Generated with Claude Code