fix: final gallery quality run — hero-material redesigns for bmesh-gear, gn-sdf-remesh, depsgraph-export#66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final gallery quality run. Scope: exactly three examples — bmesh-gear, gn-sdf-remesh, depsgraph-export — the three that survived two passes without reaching the house standard. No other example is touched.
The acceptance gate this run is the contact sheet: each candidate placed at equal size between
armature-bendanddamped-track-aim, passing only if the three cannot be sorted into different eras or studios. The final sheets are committed with this PR:Why previous passes under-delivered
Two rounds of "re-stage to the style doc" adjusted lighting around unchanged subjects. The defect was the subject treatment: a bare bright-steel gear face renders as one featureless gradient under area lights (reads as white plastic), the torus was lit frontally so the SDF facets — the API evidence — never glinted, and the grey-cube/green-sphere pair was never designed at all. This run changed the subjects.
Per-example before/after
rings_direction='SPHERICAL'. Material name changedSteel→MachinedBrass(render-path only; the check is topology-only). Alt text updated.Rules compliance
Ceramicmaterial rides through the GNSet Materialnode — the material keeps its name and slot; only color/roughness values changed, and the check passes on both versions.scripts/build_gallery.py; no hand-edits to generated pages or release-owned fields; per-example commits.Whole-gallery confirmation
The regenerated gallery was served locally (
python -m http.serverfromdocs/), loaded in a real browser with lazy-loading defeated, and scrolled end to end: no remaining card reads as old-era. No out-of-scope defect was found that needs flagging.Proven by live run: all check paths (both Blender versions), all renders (5.1.2 EEVEE), every candidate inspected at full size, card crop, and thumbnail, plus the contact-sheet gate per candidate. Inspection only: Cycles render paths and 4.5 EEVEE-Next render paths (engine-agnostic scene code behind the existing gate; CI smoke is check-only by design).
🤖 Generated with Claude Code