#650 Add stereotype for occurrence constraints #675

AndreaPuffo · 2026-01-02T09:45:49Z

Addresses #650.

Adds a new SynthML page to IntervalConstraints so it is easier to specify occurrence constraints: it automatically creates an Interval specification and the LiteralIntegers bounds if necessary.

In SynthML it looks like this:

PokaYokeProfileServices: add methods for occurrence constraint stereotype. PokaYokeUmlProfileUtil: add methods for occurrence constraint stereotype.

dhendriks · 2026-01-06T14:19:30Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        }
+
+        Verify.verify(interval instanceof Interval,
+                String.format("Interval constraint '%s' must have an interval specification.", constraint.getName()));


What happens if an exception is thrown in the UI when editing? Should it be robust in the service class, catching the exception and returning an empty string or so?

What happens if an exception is thrown in the UI when editing?

An exception is thrown in the console, in the UI nothing happens.

Should it be robust in the service class, catching the exception and returning an empty string or so?

As far as I can tell, the service class only handles errors in setMinValue and setMaxValue with a try/catch. The rest of error handling is in this class. I am assuming that this error handling comment could be extended to several other methods in this class; perhaps it is worth to have a look for it all over.

OK, so it won't give error popups then. Then it is probably good enough for now. Although, I hop it won't leave the model in an unrepairable inconsistent/invalid state? Maybe we should create a new industrialization issue for this then, to fix that in general.

Created #678.

dhendriks · 2026-01-06T14:19:38Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+    public static void setIntervalConstraintMax(IntervalConstraint constraint, String maxValue) {
+        applyStereotype(constraint, getPokaYokeProfile(constraint).getOwnedStereotype(ST_OCCURRENCE));
+
+        if (Strings.isNullOrEmpty(maxValue) && getIntervalConstraintMin(constraint).isEmpty()) {


So, the constrained elements are not under control of the stereotype? It seems they are not on this new tab? Where are they specified?

That's correct: the constrained elements still need to be specified in the 'Advanced' tab. I tried to create some selection widget to be included in the SynthML tab, but I could not get something decent to work, I am not too familiar with Sirius and related stuff. If you think this would be nice to have, I can spend some more time on it.

For now, let's not do that the. Could always do it later. This solves the most immediate need. Let's not close the issue then, move it to industrialization afterwards.

Added a comment in #650, see #650 (comment).

dhendriks · 2026-01-06T14:19:44Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        applyStereotype(constraint, getPokaYokeProfile(constraint).getOwnedStereotype(ST_OCCURRENCE));
+
+        if (Strings.isNullOrEmpty(maxValue) && getIntervalConstraintMin(constraint).isEmpty()) {
+            PokaYokeUmlProfileUtil.unapplyStereotype(constraint, OCCURRENCE_STEREOTYPE);


If the stereotype is unapplied, it will next potentially create a new interval, and set the interval. That is not desired, right?

If the stereotype is unapplied, there two options:

the constraint already had a child Interval specification, at which point the child remains but without any max/min bounds. The validator will pick up that this is not a valid model. I thought that if a user unsets both max and min, the user should also remove the IntervalConstraint as well, at which point the child interval is removed as well.

the constraint does not have an interval child, at which point a new Interval is created but never assigned, so it never gets saved into the UML model.

This would then not modify the model, but only because the parsing of "" as int would throw an exception. I guess it works.

dhendriks · 2026-01-06T14:20:01Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+                : (Interval)constraint.getSpecification();
+
+        // If the given string is empty, remove the interval's maximum.
+        if (maxValue.isEmpty()) {


above, it can also be null and then it would crash here, right?

maxValue can be an empty string, can never be null.

But then why above do you use Strings.isNullOrEmpty(maxValue)? It seem inconsistent?

dhendriks · 2026-01-06T14:20:06Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+
+        // If the given string is empty, remove the interval's maximum.
+        if (maxValue.isEmpty()) {
+            if (interval != null && interval.getMax() != null) {


how can interval be null, as we check that above and create a new one if it is null?

dhendriks · 2026-01-06T14:20:24Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+            return;
+        }
+
+        setIntervalMax(constraint, interval, Integer.parseInt(maxValue));


will this crash the UI if it is not an integer or a too large integer, etc?

Again, an exception in the console, nothing happens in the UI (for both cases). Will be picked up by the validator later on.

dhendriks · 2026-01-06T14:21:35Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        return occurrenceConstraints.stream()
+                .filter(o -> o.getSpecification() instanceof Interval interval
+                        && (Objects.equals(interval.getMax(), lit) || Objects.equals(interval.getMin(), lit)))
+                .map(o -> o.getSpecification()).map(Interval.class::cast).collect(Collectors.toSet());


I'd maybe return a list. You go over the model and can never find duplicates, right? Or are these referred instead of contained here?

A list should be good indeed.

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

dhendriks · 2026-01-06T14:22:14Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        return newLiteral;
+    }
+
+    private static List<LiteralInteger> getAllLiteralIntegersWithValue(Model model, int value) {


Since you only use one, you could make this getFirstLiteralIntegerWithValue, with on the stream findFirst, which is more efficient.

dhendriks · 2026-01-06T14:22:57Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        LiteralInteger maxLiteral = getLiteralInteger(constraint, maxValue);
+
+        // Remove the old literal integer, if possible.
+        LiteralInteger currentIntegerBound = (LiteralInteger)interval.getMax();


Won't this crash in the UI if it is not a LiteralInteger?

See previous replies.

- move max/min methods close - `findAllIntervalsReferencing` returns a List - remove useless `interval != null` from `setIntervalConstraintMax` and `setIntervalConstraintMin`

`getFirstLiteralIntegersWithValue` and update return value accordingly

dhendriks · 2026-01-06T16:14:30Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+                : (Interval)constraint.getSpecification();
+
+        // If the given string is empty, remove the interval's maximum.
+        if (maxValue.isEmpty()) {


But then why above do you use Strings.isNullOrEmpty(maxValue)? It seem inconsistent?

dhendriks · 2026-01-06T16:15:34Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+    public static void setIntervalConstraintMax(IntervalConstraint constraint, String maxValue) {
+        applyStereotype(constraint, getPokaYokeProfile(constraint).getOwnedStereotype(ST_OCCURRENCE));
+
+        if (Strings.isNullOrEmpty(maxValue) && getIntervalConstraintMin(constraint).isEmpty()) {


For now, let's not do that the. Could always do it later. This solves the most immediate need. Let's not close the issue then, move it to industrialization afterwards.

dhendriks · 2026-01-06T16:16:51Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        }
+
+        Verify.verify(interval instanceof Interval,
+                String.format("Interval constraint '%s' must have an interval specification.", constraint.getName()));


OK, so it won't give error popups then. Then it is probably good enough for now. Although, I hop it won't leave the model in an unrepairable inconsistent/invalid state? Maybe we should create a new industrialization issue for this then, to fix that in general.

dhendriks · 2026-01-06T16:17:08Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        constraint.setSpecification(interval);
+    }
+
+    private static void setIntervalMin(Constraint constraint, Interval interval, int minValue) {


Next time, if you move methods around, do that in a separate commit, and make no other changes in that commit. Now I have to see in the move what else you changed at the same time, which takes extra time.

dhendriks · 2026-01-06T16:20:25Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

+        applyStereotype(constraint, getPokaYokeProfile(constraint).getOwnedStereotype(ST_OCCURRENCE));
+
+        if (Strings.isNullOrEmpty(maxValue) && getIntervalConstraintMin(constraint).isEmpty()) {
+            PokaYokeUmlProfileUtil.unapplyStereotype(constraint, OCCURRENCE_STEREOTYPE);


This would then not modify the model, but only because the parsing of "" as int would throw an exception. I guess it works.

AndreaPuffo · 2026-01-07T08:30:10Z

Ready for review.

dhendriks · 2026-01-07T09:36:25Z

I've updated the PR description to indicate that this addresses (rather than closes) the issue. Still, GitHub will close it, so we should re-open it after merging this PR.

AndreaPuffo added 4 commits December 22, 2025 15:42

#650 Update profile plugin with new stereotype Occurrence

7977dd1

#650 Update .odesign file

aed6358

#650 Update profile services and UML profile util.

33b1ec7

PokaYokeProfileServices: add methods for occurrence constraint stereotype. PokaYokeUmlProfileUtil: add methods for occurrence constraint stereotype.

#650 Update SynthML profile diagram

8907f10

AndreaPuffo linked an issue Jan 2, 2026 that may be closed by this pull request

UML to CIF translation: add stereotype for occurrence constraints #650

Open

dhendriks requested changes Jan 6, 2026

View reviewed changes

AndreaPuffo added 2 commits January 6, 2026 16:40

#650 PokaYokeUmlProfileUtil:

609f083

- move max/min methods close - `findAllIntervalsReferencing` returns a List - remove useless `interval != null` from `setIntervalConstraintMax` and `setIntervalConstraintMin`

#650 PokaYokeUmlProfileUtil: rename method

c67a03a

`getFirstLiteralIntegersWithValue` and update return value accordingly

dhendriks requested changes Jan 6, 2026

View reviewed changes

AndreaPuffo mentioned this pull request Jan 7, 2026

UML to CIF translation: add stereotype for occurrence constraints #650

Open

#650 PokaYokeUmlProfileUtil: minor fix

586ba8d

dhendriks approved these changes Jan 7, 2026

View reviewed changes

AndreaPuffo merged commit 0fa86dc into main Jan 9, 2026

AndreaPuffo deleted the 650-uml-to-cif-translation-add-stereotype-for-occurrence-constraints branch January 9, 2026 08:34

#650 Add stereotype for occurrence constraints #675

#650 Add stereotype for occurrence constraints #675

Uh oh!

Conversation

AndreaPuffo commented Jan 2, 2026 • edited by dhendriks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreaPuffo commented Jan 7, 2026

Uh oh!

dhendriks commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndreaPuffo commented Jan 2, 2026 •

edited by dhendriks

Loading