-
Notifications
You must be signed in to change notification settings - Fork 10
🐎 RLE for memory in snapshots #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💥 Breaking change warning |
|
I want to add this change for the new major release @MaartenS11 |
5f84da6 to
867c0db
Compare
|
@MaartenS11 so you implemented a simple run-length encoding yourselves? And it just shortens consecutive strings as the pattern and number of occurrences separated by a comma? Is that correct? |
It's |
tolauwae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although I would move the RLE to separate util functions.
But can be merged as is.
Currently only uses run length encoding to transfer snapshots from the microcontroller to the computer, not the other way around. The VSCode plugin will need changes to be able to reconstruct the actual bytes in memory.