Skip to content

🐎 RLE for memory in snapshots #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 14, 2024
Merged

🐎 RLE for memory in snapshots #264

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0f97a46
Use run length encoding when taking a memory snapshot
MaartenS11 Sep 26, 2024
3f7d515
Fix issue with run length encoding when there are 0 memory pages
MaartenS11 Sep 26, 2024
be9cd29
Restore memory using run length encoding
MaartenS11 Nov 20, 2024
3b7c88e
Remove old commented out code
MaartenS11 Nov 25, 2024
cd93f1e
Clang-format
MaartenS11 Nov 25, 2024
e4b0068
Remove unnecessary print
MaartenS11 Nov 25, 2024
867c0db
Add check to validate if run length encoding restored memory correctly
MaartenS11 Nov 25, 2024
9e12434
Fix conflicting variable name `end`
MaartenS11 Nov 25, 2024
9b42dd7
Merge branch 'main' into feat/run-length-memory
tolauwae Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions src/Debug/debugger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,24 @@ void Debugger::inspect(Module *m, const uint16_t sizeStateArray,
addComma ? "," : "", m->memory.pages, m->memory.maximum,
m->memory.initial);
addComma = true;
for (uint32_t j = 0; j < total_elems; j++) {
this->channel->write("%" PRIu8 "%s", m->memory.bytes[j],
(j + 1) == total_elems ? "" : ",");
if (total_elems != 0) {
uint8_t data = m->memory.bytes[0];
uint32_t count = 1;
bool arrayComma = false;
for (uint32_t j = 1; j < total_elems; j++) {
if (m->memory.bytes[j] == data) {
count++;
} else {
this->channel->write("%s%" PRIu8 ",%d",
arrayComma ? "," : "", data,
count);
arrayComma = true;
data = m->memory.bytes[j];
count = 1;
}
}
this->channel->write("%s%" PRIu8 ",%d",
arrayComma ? "," : "", data, count);
}
this->channel->write("]}"); // closing memory
break;
Expand Down Expand Up @@ -1237,12 +1252,24 @@ bool Debugger::saveState(Module *m, uint8_t *interruptData) {
static_cast<void *>(m->bytes + start + total_bytes),
static_cast<void *>(mem_end));
}
memcpy(m->memory.bytes + start, program_state, total_bytes);

uint32_t byte_count = read_B32(&program_state);
uint8_t *end_pos = program_state + byte_count;
uint32_t current_pos = start;
while (program_state < end_pos) {
uint32_t count = read_LEB_32(&program_state);
uint8_t byte = *program_state++;
memset(m->memory.bytes + current_pos, byte, count);
current_pos += count;
}
if (current_pos != limit + 1) {
FATAL("RLE did not restore the expected amount of bytes\n");
}

for (auto i = start; i < (start + total_bytes); i++) {
debug("GOT byte idx %" PRIu32 " =%" PRIu8 "\n", i,
m->memory.bytes[i]);
}
program_state += total_bytes;
break;
}
case branchingTableState: {
Expand Down
Loading