[BUGFIX] Ensure consistent handling of else-if ViewHelpers#1025
Merged
Conversation
s2b
force-pushed
the
bugfix/elseIfUncached
branch
2 times, most recently
from
c1e2568 to
c96dfaf
Compare
A f:if ViewHelper that contains else-if ViewHelpers and also sets the else attribute behaved differently for cached and uncached templates. With this change, uncached templates now behave just like cached templates. This can be validated by temporarily commenting out the second test execution code in IfThenElseViewHelperTest::render(). This testing setup issue should also be fixed in the future, but this is out of scope for the specific issue.
s2b
force-pushed
the
bugfix/elseIfUncached
branch
from
c96dfaf to
7e78e17
Compare
lolli42
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A f:if ViewHelper that contains else-if ViewHelpers and also sets the else attribute behaved differently for cached and uncached templates. With this change, uncached templates now behave just like cached templates.
This can be validated by temporarily commenting out the second test execution code in IfThenElseViewHelperTest::render(). This testing setup issue should also be fixed in the future, but this is out of scope for the specific issue.